You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "yndu13 (via GitHub)" <gi...@apache.org> on 2023/09/04 04:19:23 UTC
[GitHub] [httpcomponents-core] yndu13 opened a new pull request, #427: Supports SOCKS5 proxy with username/password authentication
yndu13 opened a new pull request, #427:
URL: https://github.com/apache/httpcomponents-core/pull/427
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] ok2c commented on pull request #427: Support SOCKS5 proxy with username/password authentication
Posted by "ok2c (via GitHub)" <gi...@apache.org>.
ok2c commented on PR #427:
URL: https://github.com/apache/httpcomponents-core/pull/427#issuecomment-1705145516
@yndu13 Looks correct to me. I am still trying to test the fix locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] yndu13 commented on pull request #427: Support SOCKS5 proxy with username/password authentication
Posted by "yndu13 (via GitHub)" <gi...@apache.org>.
yndu13 commented on PR #427:
URL: https://github.com/apache/httpcomponents-core/pull/427#issuecomment-1704592623
@ok2c Can someone give a review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] yndu13 commented on pull request #427: Support SOCKS5 proxy with username/password authentication
Posted by "yndu13 (via GitHub)" <gi...@apache.org>.
yndu13 commented on PR #427:
URL: https://github.com/apache/httpcomponents-core/pull/427#issuecomment-1705165517
> @yndu13 Looks correct to me. I am still trying to test the fix locally.
Thanks, you can use this [socks server](https://github.com/serjs/socks5-server) to verify this problem.
The following is the result of my test:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] ok2c merged pull request #427: Support SOCKS5 proxy with username/password authentication
Posted by "ok2c (via GitHub)" <gi...@apache.org>.
ok2c merged PR #427:
URL: https://github.com/apache/httpcomponents-core/pull/427
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] garydgregory commented on pull request #427: Support SOCKS5 proxy with username/password authentication
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #427:
URL: https://github.com/apache/httpcomponents-core/pull/427#issuecomment-1705169527
Hi @yndu13
Thank you for your PR.
Without a matching test, this change in behavior can be undone in the future without anyone noticing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] ok2c commented on pull request #427: Support SOCKS5 proxy with username/password authentication
Posted by "ok2c (via GitHub)" <gi...@apache.org>.
ok2c commented on PR #427:
URL: https://github.com/apache/httpcomponents-core/pull/427#issuecomment-1705224802
> Thanks, you can use this [socks server](https://github.com/serjs/socks5-server) to verify this problem.
@yndu13 I tested it with [Dante](https://www.inet.no/dante/).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] yndu13 commented on pull request #427: Support SOCKS5 proxy with username/password authentication
Posted by "yndu13 (via GitHub)" <gi...@apache.org>.
yndu13 commented on PR #427:
URL: https://github.com/apache/httpcomponents-core/pull/427#issuecomment-1705190444
> Hi @yndu13 Thank you for your PR. Without a matching test, this change in behavior can be undone in the future without anyone noticing.
I agree with this opinion, but this test feels difficult to write. Emmm, let me think about it. Feel like adding an integration test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org