[jira] Commented: (MAHOUT-159) SparseVector and DenseVector hashCode does not conform to the Java standard

["Grant Ingersoll (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAHOUT-159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12741065#action_12741065 ] 

Grant Ingersoll commented on MAHOUT-159:
----------------------------------------

My only suggestion is that the hashCode method should use the iterateNonZeros() method instead of iterating over size().

> SparseVector and DenseVector hashCode does not conform to the Java standard
> ---------------------------------------------------------------------------
>
>                 Key: MAHOUT-159
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-159
>             Project: Mahout
>          Issue Type: Bug
>          Components: Matrix
>    Affects Versions: 0.2
>            Reporter: Mark Desnoyer
>            Assignee: Grant Ingersoll
>            Priority: Critical
>         Attachments: MAHOUT-159.patch, MAHOUT-159.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> The hash codes for SparseVector and DenseVector will not be equal even though equals() may return true. Also, the equals logic is inconsistent because DenseVector takes into account the name parameter but SparseVector does not.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.