[GitHub] [superset] villebro commented on a change in pull request #16414: feat: Improve sorting for new chart dataset select

[GitBox <gi...@apache.org>]

villebro commented on a change in pull request #16414:
URL: https://github.com/apache/superset/pull/16414#discussion_r695689158



##########
File path: superset-frontend/src/addSlice/AddSliceContainer.tsx
##########
@@ -194,6 +196,8 @@ export default class AddSliceContainer extends React.PureComponent<
     this.newLabel = this.newLabel.bind(this);
     this.loadDatasources = this.loadDatasources.bind(this);
     this.handleFilterOption = this.handleFilterOption.bind(this);

Review comment:
       This would probably be best to add to FAB to avoid having to implement this in every endpoint (I didn't check if there's a filter operator for this specific case, but I doubt it). We could do a two-phase request, where we first look for an exact match and then do the regular match after that, placing the exact match on top if present and adjusting the limit and offset of the regular match accordingly. I could potentially take a stab at doing this if we can agree on the details.
   
   I agree with @michael-s-molina that we should really try to handle sorting server side to make the product handle arbitrarily large datasets well.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org