[GitHub] [accumulo] arvindshmicrosoft commented on a change in pull request #1575: Skip restricted ports in TServer port search

[GitBox <gi...@apache.org>]

arvindshmicrosoft commented on a change in pull request #1575: Skip restricted ports in TServer port search
URL: https://github.com/apache/accumulo/pull/1575#discussion_r399757871
 
 

 ##########
 File path: server/base/src/main/java/org/apache/accumulo/server/rpc/TServerUtils.java
 ##########
 @@ -168,10 +171,33 @@ public static ServerAddress startServer(MetricsSystem metricsSystem, ServerConte
           addresses);
     } catch (TTransportException e) {
       if (portSearch) {
+        // Build a list of reserved ports - as identified by properties of type PropertyType.PORT
+        ArrayList<Integer> restrictedPorts = new ArrayList<Integer>();
+        for (Property p : Property.values()) {
+          if (p.getType().equals(PropertyType.PORT)) {
 
 Review comment:
   Thanks! Will incorporate these. I also realized that TSERV_CLIENTPORT should not be skipped as it is a valid port for the TServer to use even if port search is enabled.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services