[GitHub] [incubator-mxnet] zhreshold commented on a change in pull request #14823: [int8] Add MobileNetV2_1.0 & ResNet18 Quantization

[GitBox <gi...@apache.org>]

zhreshold commented on a change in pull request #14823: [int8] Add MobileNetV2_1.0 & ResNet18 Quantization
URL: https://github.com/apache/incubator-mxnet/pull/14823#discussion_r279486680
 
 

 ##########
 File path: example/quantization/imagenet_gen_qsym_mkldnn.py
 ##########
 @@ -234,6 +242,12 @@ def save_params(fname, arg_params, aux_params, logger=None):
                                'mobilenet0_pool0_fwd']
         if exclude_first_conv:
             excluded_sym_names += ['mobilenet0_conv0_fwd']
+    elif args.model == 'mobilenetv2_1.0':
+        rgb_mean = '123.68,116.779,103.939'
 
 Review comment:
   is there any exception that the rgb_mean dna std is not the same? otherwise repeatively coding it looks redundant

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services