[GitHub] [bookkeeper] eolivelli commented on a change in pull request #1949: [bookie-gc] add option to cache entry-log metadata map into rocksDB

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #1949: [bookie-gc] add option to cache entry-log metadata map into rocksDB
URL: https://github.com/apache/bookkeeper/pull/1949#discussion_r326898986
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java
 ##########
 @@ -1560,6 +1560,15 @@ public static boolean format(ServerConfiguration conf,
                     }
                 }
             }
+
+            // Clean up metadata directories if they are separate from the
+            // ledger dirs
+            File metadataDir = new File(conf.getGcEntryLogMetadataCachePath());
 
 Review comment:
   is this code to be executed only if the feature is enabled?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services