You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/10/21 10:41:56 UTC
[GitHub] [flink] zentol opened a new pull request #17535: [FLINK-24609][akka][build] Use same Scala properties as root pom
zentol opened a new pull request #17535:
URL: https://github.com/apache/flink/pull/17535
Maven does not properly resolve `dependencyManagement` entries if the parent/child module declare one for the same dependency with different properties being used in the `artifactId.` Our builds were only as expected because we were accidentally using the plain `scala.binary.version` property for `parser-combinators.`
Hence we unfortunately need to use the same property names, which should however not cause issues in the future (if say, a 2.13 profile is introduced), because the properties defined in the child take precedence.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17535: [FLINK-24609][akka][build] Use same Scala properties as root pom
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17535:
URL: https://github.com/apache/flink/pull/17535#issuecomment-948487840
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "743640e83c9caed3f2af3c94ce4aee6228d244bb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25313",
"triggerID" : "743640e83c9caed3f2af3c94ce4aee6228d244bb",
"triggerType" : "PUSH"
}, {
"hash" : "743640e83c9caed3f2af3c94ce4aee6228d244bb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25313",
"triggerID" : "951886912",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 743640e83c9caed3f2af3c94ce4aee6228d244bb Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25313)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dmvk commented on a change in pull request #17535: [FLINK-24609][akka][build] Use same Scala properties as root pom
Posted by GitBox <gi...@apache.org>.
dmvk commented on a change in pull request #17535:
URL: https://github.com/apache/flink/pull/17535#discussion_r737459359
##########
File path: flink-rpc/flink-rpc-akka/pom.xml
##########
@@ -35,8 +35,8 @@ under the License.
<properties>
<akka.version>2.6.15</akka.version>
- <akka.scala.binary.version>2.12</akka.scala.binary.version>
- <akka.scala.version>2.12.7</akka.scala.version>
+ <scala.binary.version>2.12</scala.binary.version>
+ <scala.version>2.12.7</scala.version>
Review comment:
Why do we need to explicitly re-set the properties here instead of using the inherited ones?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dmvk commented on pull request #17535: [FLINK-24609][akka][build] Use same Scala properties as root pom
Posted by GitBox <gi...@apache.org>.
dmvk commented on pull request #17535:
URL: https://github.com/apache/flink/pull/17535#issuecomment-951886912
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17535: [FLINK-24609][akka][build] Use same Scala properties as root pom
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17535:
URL: https://github.com/apache/flink/pull/17535#issuecomment-948487840
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "743640e83c9caed3f2af3c94ce4aee6228d244bb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25313",
"triggerID" : "743640e83c9caed3f2af3c94ce4aee6228d244bb",
"triggerType" : "PUSH"
}, {
"hash" : "743640e83c9caed3f2af3c94ce4aee6228d244bb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25313",
"triggerID" : "951886912",
"triggerType" : "MANUAL"
}, {
"hash" : "906e27be8cc278d75fd10d5216ca34275168df96",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "906e27be8cc278d75fd10d5216ca34275168df96",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 743640e83c9caed3f2af3c94ce4aee6228d244bb Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25313)
* 906e27be8cc278d75fd10d5216ca34275168df96 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dmvk edited a comment on pull request #17535: [FLINK-24609][akka][build] Use same Scala properties as root pom
Posted by GitBox <gi...@apache.org>.
dmvk edited a comment on pull request #17535:
URL: https://github.com/apache/flink/pull/17535#issuecomment-952903426
CI Failed with https://issues.apache.org/jira/browse/FLINK-24662, should be already fixed on master (I think there is no need to re-run)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17535: [FLINK-24609][akka][build] Use same Scala properties as root pom
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17535:
URL: https://github.com/apache/flink/pull/17535#issuecomment-948487840
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "743640e83c9caed3f2af3c94ce4aee6228d244bb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25313",
"triggerID" : "743640e83c9caed3f2af3c94ce4aee6228d244bb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 743640e83c9caed3f2af3c94ce4aee6228d244bb Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25313)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17535: [FLINK-24609][akka][build] Use same Scala properties as root pom
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17535:
URL: https://github.com/apache/flink/pull/17535#issuecomment-948485608
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 743640e83c9caed3f2af3c94ce4aee6228d244bb (Thu Oct 21 10:44:47 UTC 2021)
**Warnings:**
* **1 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17535: [FLINK-24609][akka][build] Use same Scala properties as root pom
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17535:
URL: https://github.com/apache/flink/pull/17535#issuecomment-948487840
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "743640e83c9caed3f2af3c94ce4aee6228d244bb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "743640e83c9caed3f2af3c94ce4aee6228d244bb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 743640e83c9caed3f2af3c94ce4aee6228d244bb UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17535: [FLINK-24609][akka][build] Use same Scala properties as root pom
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17535:
URL: https://github.com/apache/flink/pull/17535#issuecomment-948487840
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "743640e83c9caed3f2af3c94ce4aee6228d244bb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25313",
"triggerID" : "743640e83c9caed3f2af3c94ce4aee6228d244bb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 743640e83c9caed3f2af3c94ce4aee6228d244bb Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25313)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #17535: [FLINK-24609][akka][build] Use same Scala properties as root pom
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #17535:
URL: https://github.com/apache/flink/pull/17535#discussion_r737732539
##########
File path: flink-rpc/flink-rpc-akka/pom.xml
##########
@@ -35,8 +35,8 @@ under the License.
<properties>
<akka.version>2.6.15</akka.version>
- <akka.scala.binary.version>2.12</akka.scala.binary.version>
- <akka.scala.version>2.12.7</akka.scala.version>
+ <scala.binary.version>2.12</scala.binary.version>
+ <scala.version>2.12.7</scala.version>
Review comment:
Because we want to use a specific version. If we add support for Scala 2.13 (which entails adding a profile which sets scala.[binary.]version), we still want to use 2.12 here because the RPC system it self-contained and independent from the APIs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol merged pull request #17535: [FLINK-24609][akka][build] Use same Scala properties as root pom
Posted by GitBox <gi...@apache.org>.
zentol merged pull request #17535:
URL: https://github.com/apache/flink/pull/17535
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17535: [FLINK-24609][akka][build] Use same Scala properties as root pom
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17535:
URL: https://github.com/apache/flink/pull/17535#issuecomment-948487840
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "743640e83c9caed3f2af3c94ce4aee6228d244bb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25313",
"triggerID" : "743640e83c9caed3f2af3c94ce4aee6228d244bb",
"triggerType" : "PUSH"
}, {
"hash" : "743640e83c9caed3f2af3c94ce4aee6228d244bb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25313",
"triggerID" : "951886912",
"triggerType" : "MANUAL"
}, {
"hash" : "906e27be8cc278d75fd10d5216ca34275168df96",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25471",
"triggerID" : "906e27be8cc278d75fd10d5216ca34275168df96",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 743640e83c9caed3f2af3c94ce4aee6228d244bb Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25313)
* 906e27be8cc278d75fd10d5216ca34275168df96 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25471)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dmvk commented on pull request #17535: [FLINK-24609][akka][build] Use same Scala properties as root pom
Posted by GitBox <gi...@apache.org>.
dmvk commented on pull request #17535:
URL: https://github.com/apache/flink/pull/17535#issuecomment-952903426
CI Failed with https://issues.apache.org/jira/browse/FLINK-24662, should be already fixed on master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17535: [FLINK-24609][akka][build] Use same Scala properties as root pom
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17535:
URL: https://github.com/apache/flink/pull/17535#issuecomment-948487840
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "743640e83c9caed3f2af3c94ce4aee6228d244bb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25313",
"triggerID" : "743640e83c9caed3f2af3c94ce4aee6228d244bb",
"triggerType" : "PUSH"
}, {
"hash" : "743640e83c9caed3f2af3c94ce4aee6228d244bb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25313",
"triggerID" : "951886912",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 743640e83c9caed3f2af3c94ce4aee6228d244bb Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25313)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17535: [FLINK-24609][akka][build] Use same Scala properties as root pom
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17535:
URL: https://github.com/apache/flink/pull/17535#issuecomment-948487840
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "743640e83c9caed3f2af3c94ce4aee6228d244bb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25313",
"triggerID" : "743640e83c9caed3f2af3c94ce4aee6228d244bb",
"triggerType" : "PUSH"
}, {
"hash" : "743640e83c9caed3f2af3c94ce4aee6228d244bb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25313",
"triggerID" : "951886912",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 743640e83c9caed3f2af3c94ce4aee6228d244bb Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25313)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17535: [FLINK-24609][akka][build] Use same Scala properties as root pom
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17535:
URL: https://github.com/apache/flink/pull/17535#issuecomment-948487840
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "743640e83c9caed3f2af3c94ce4aee6228d244bb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25313",
"triggerID" : "743640e83c9caed3f2af3c94ce4aee6228d244bb",
"triggerType" : "PUSH"
}, {
"hash" : "743640e83c9caed3f2af3c94ce4aee6228d244bb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25313",
"triggerID" : "951886912",
"triggerType" : "MANUAL"
}, {
"hash" : "906e27be8cc278d75fd10d5216ca34275168df96",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25471",
"triggerID" : "906e27be8cc278d75fd10d5216ca34275168df96",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 906e27be8cc278d75fd10d5216ca34275168df96 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25471)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org