You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2015/06/05 07:52:12 UTC
Re: Review Request 34970: Cleaned up and generalized
NoExecutorScheduler to be more configurable.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34970/
-----------------------------------------------------------
(Updated June 5, 2015, 5:52 a.m.)
Review request for mesos, Jie Yu and Vinod Kone.
Changes
-------
Re-worked to generalize the existing NoExecutorScheduler.
Summary (updated)
-----------------
Cleaned up and generalized NoExecutorScheduler to be more configurable.
Bugs: MESOS-2655
https://issues.apache.org/jira/browse/MESOS-2655
Repository: mesos
Description (updated)
-------
Now the NoExecutorScheduler can take a custom command, as well as the resources for the task and how many tasks to run.
This allows us to continue using it for an end-to-end test as part of make check, but also allows it to be used against a cluster in a long-lived fashion.
Diffs (updated)
-----
src/examples/no_executor_framework.cpp 37001c389f31f9f1dafe6d7f3eb17adc2e369057
src/tests/no_executor_framework_test.sh d2d395595b778bc543e1baaa0fd415dc622b647f
src/tests/script.cpp 515e3141e1d517da4cfc1421d5301d0a3bd6ad51
Diff: https://reviews.apache.org/r/34970/diff/
Testing (updated)
-------
The existing no executor framework test picks this up.
Since we do not have an non-zero estimator yet, I modified the slave to send revocable resources in order to manually test the revocable case.
Thanks,
Ben Mahler
Re: Review Request 34970: Cleaned up and generalized
NoExecutorScheduler to be more configurable.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34970/#review86840
-----------------------------------------------------------
Patch looks great!
Reviews applied: [34968, 34969, 34970]
All tests passed.
- Mesos ReviewBot
On June 5, 2015, 7:56 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34970/
> -----------------------------------------------------------
>
> (Updated June 5, 2015, 7:56 p.m.)
>
>
> Review request for mesos, Jie Yu and Vinod Kone.
>
>
> Bugs: MESOS-2655
> https://issues.apache.org/jira/browse/MESOS-2655
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Now the NoExecutorScheduler can take a custom command, as well as the resources for the task and how many tasks to run.
>
> This allows us to continue using it for an end-to-end test as part of make check, but also allows it to be used against a cluster in a long-lived fashion.
>
>
> Diffs
> -----
>
> src/examples/no_executor_framework.cpp 1fb853d6e4a3deb3c36e6e661689697c8ebf898f
> src/tests/no_executor_framework_test.sh d2d395595b778bc543e1baaa0fd415dc622b647f
> src/tests/script.cpp 515e3141e1d517da4cfc1421d5301d0a3bd6ad51
>
> Diff: https://reviews.apache.org/r/34970/diff/
>
>
> Testing
> -------
>
> The existing no executor framework test picks this up.
>
> Since we do not have an non-zero estimator yet, I modified the slave to send revocable resources in order to manually test the revocable case.
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 34970: Cleaned up and generalized
NoExecutorScheduler to be more configurable.
Posted by Ben Mahler <be...@gmail.com>.
> On June 5, 2015, 9:37 p.m., Vinod Kone wrote:
> > src/examples/no_executor_framework.cpp, line 219
> > <https://reviews.apache.org/r/34970/diff/2/?file=979734#file979734line219>
> >
> > LOG(FATAL)? because this is not possible with a command executor?
Sure, this was to stay consistent with the other examples (e.g. persistent_volume_framework.cpp), but I'll change it.
> On June 5, 2015, 9:37 p.m., Vinod Kone wrote:
> > src/examples/no_executor_framework.cpp, line 253
> > <https://reviews.apache.org/r/34970/diff/2/?file=979734#file979734line253>
> >
> > s/active/launched/ ?
This is all non-terminal (i.e. active) tasks. Launched seems to imply everything ever launched, no?
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34970/#review86846
-----------------------------------------------------------
On June 5, 2015, 7:56 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34970/
> -----------------------------------------------------------
>
> (Updated June 5, 2015, 7:56 p.m.)
>
>
> Review request for mesos, Jie Yu and Vinod Kone.
>
>
> Bugs: MESOS-2655
> https://issues.apache.org/jira/browse/MESOS-2655
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Now the NoExecutorScheduler can take a custom command, as well as the resources for the task and how many tasks to run.
>
> This allows us to continue using it for an end-to-end test as part of make check, but also allows it to be used against a cluster in a long-lived fashion.
>
>
> Diffs
> -----
>
> src/examples/no_executor_framework.cpp 1fb853d6e4a3deb3c36e6e661689697c8ebf898f
> src/tests/no_executor_framework_test.sh d2d395595b778bc543e1baaa0fd415dc622b647f
> src/tests/script.cpp 515e3141e1d517da4cfc1421d5301d0a3bd6ad51
>
> Diff: https://reviews.apache.org/r/34970/diff/
>
>
> Testing
> -------
>
> The existing no executor framework test picks this up.
>
> Since we do not have an non-zero estimator yet, I modified the slave to send revocable resources in order to manually test the revocable case.
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 34970: Cleaned up and generalized
NoExecutorScheduler to be more configurable.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34970/#review86846
-----------------------------------------------------------
Ship it!
src/examples/no_executor_framework.cpp
<https://reviews.apache.org/r/34970/#comment138944>
I think it is easier to follow if this is written as:
```
while(remaining.contains(taskResources) &&
(totalTasks.isNone() || tasksLaunched < totalTasks.get())) {
}
```
src/examples/no_executor_framework.cpp
<https://reviews.apache.org/r/34970/#comment138946>
LOG(FATAL)? because this is not possible with a command executor?
src/examples/no_executor_framework.cpp
<https://reviews.apache.org/r/34970/#comment138948>
s/active/launched/ ?
src/examples/no_executor_framework.cpp
<https://reviews.apache.org/r/34970/#comment138943>
Also mention that, if this is not specified, as many tasks as possible are launched?
src/examples/no_executor_framework.cpp
<https://reviews.apache.org/r/34970/#comment138942>
Only set this if flags.task_revocable_resources.isSome() ?
- Vinod Kone
On June 5, 2015, 7:56 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34970/
> -----------------------------------------------------------
>
> (Updated June 5, 2015, 7:56 p.m.)
>
>
> Review request for mesos, Jie Yu and Vinod Kone.
>
>
> Bugs: MESOS-2655
> https://issues.apache.org/jira/browse/MESOS-2655
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Now the NoExecutorScheduler can take a custom command, as well as the resources for the task and how many tasks to run.
>
> This allows us to continue using it for an end-to-end test as part of make check, but also allows it to be used against a cluster in a long-lived fashion.
>
>
> Diffs
> -----
>
> src/examples/no_executor_framework.cpp 1fb853d6e4a3deb3c36e6e661689697c8ebf898f
> src/tests/no_executor_framework_test.sh d2d395595b778bc543e1baaa0fd415dc622b647f
> src/tests/script.cpp 515e3141e1d517da4cfc1421d5301d0a3bd6ad51
>
> Diff: https://reviews.apache.org/r/34970/diff/
>
>
> Testing
> -------
>
> The existing no executor framework test picks this up.
>
> Since we do not have an non-zero estimator yet, I modified the slave to send revocable resources in order to manually test the revocable case.
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 34970: Cleaned up and generalized
NoExecutorScheduler to be more configurable.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34970/
-----------------------------------------------------------
(Updated June 5, 2015, 7:56 p.m.)
Review request for mesos, Jie Yu and Vinod Kone.
Changes
-------
Resolved merge conflicts for the os::getenv changes that landed.
Bugs: MESOS-2655
https://issues.apache.org/jira/browse/MESOS-2655
Repository: mesos
Description
-------
Now the NoExecutorScheduler can take a custom command, as well as the resources for the task and how many tasks to run.
This allows us to continue using it for an end-to-end test as part of make check, but also allows it to be used against a cluster in a long-lived fashion.
Diffs (updated)
-----
src/examples/no_executor_framework.cpp 1fb853d6e4a3deb3c36e6e661689697c8ebf898f
src/tests/no_executor_framework_test.sh d2d395595b778bc543e1baaa0fd415dc622b647f
src/tests/script.cpp 515e3141e1d517da4cfc1421d5301d0a3bd6ad51
Diff: https://reviews.apache.org/r/34970/diff/
Testing
-------
The existing no executor framework test picks this up.
Since we do not have an non-zero estimator yet, I modified the slave to send revocable resources in order to manually test the revocable case.
Thanks,
Ben Mahler
Re: Review Request 34970: Cleaned up and generalized
NoExecutorScheduler to be more configurable.
Posted by Ben Mahler <be...@gmail.com>.
> On June 5, 2015, 6:24 a.m., Mesos ReviewBot wrote:
> > Bad patch!
> >
> > Reviews applied: [34968, 34969, 34970]
> >
> > Failed command: ./support/apply-review.sh -n -r 34970
> >
> > Error:
> > 2015-06-05 06:24:06 URL:https://reviews.apache.org/r/34970/diff/raw/ [16370/16370] -> "34970.patch" [1]
> > error: patch failed: src/examples/no_executor_framework.cpp:16
> > error: src/examples/no_executor_framework.cpp: patch does not apply
> > Failed to apply patch
Interesting, this shouldn't have applied the previous two reviews since [MESOS-1881](https://issues.apache.org/jira/browse/MESOS-1881) is resolved.
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34970/#review86767
-----------------------------------------------------------
On June 5, 2015, 5:52 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34970/
> -----------------------------------------------------------
>
> (Updated June 5, 2015, 5:52 a.m.)
>
>
> Review request for mesos, Jie Yu and Vinod Kone.
>
>
> Bugs: MESOS-2655
> https://issues.apache.org/jira/browse/MESOS-2655
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Now the NoExecutorScheduler can take a custom command, as well as the resources for the task and how many tasks to run.
>
> This allows us to continue using it for an end-to-end test as part of make check, but also allows it to be used against a cluster in a long-lived fashion.
>
>
> Diffs
> -----
>
> src/examples/no_executor_framework.cpp 37001c389f31f9f1dafe6d7f3eb17adc2e369057
> src/tests/no_executor_framework_test.sh d2d395595b778bc543e1baaa0fd415dc622b647f
> src/tests/script.cpp 515e3141e1d517da4cfc1421d5301d0a3bd6ad51
>
> Diff: https://reviews.apache.org/r/34970/diff/
>
>
> Testing
> -------
>
> The existing no executor framework test picks this up.
>
> Since we do not have an non-zero estimator yet, I modified the slave to send revocable resources in order to manually test the revocable case.
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 34970: Cleaned up and generalized
NoExecutorScheduler to be more configurable.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34970/#review86767
-----------------------------------------------------------
Bad patch!
Reviews applied: [34968, 34969, 34970]
Failed command: ./support/apply-review.sh -n -r 34970
Error:
2015-06-05 06:24:06 URL:https://reviews.apache.org/r/34970/diff/raw/ [16370/16370] -> "34970.patch" [1]
error: patch failed: src/examples/no_executor_framework.cpp:16
error: src/examples/no_executor_framework.cpp: patch does not apply
Failed to apply patch
- Mesos ReviewBot
On June 5, 2015, 5:52 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34970/
> -----------------------------------------------------------
>
> (Updated June 5, 2015, 5:52 a.m.)
>
>
> Review request for mesos, Jie Yu and Vinod Kone.
>
>
> Bugs: MESOS-2655
> https://issues.apache.org/jira/browse/MESOS-2655
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Now the NoExecutorScheduler can take a custom command, as well as the resources for the task and how many tasks to run.
>
> This allows us to continue using it for an end-to-end test as part of make check, but also allows it to be used against a cluster in a long-lived fashion.
>
>
> Diffs
> -----
>
> src/examples/no_executor_framework.cpp 37001c389f31f9f1dafe6d7f3eb17adc2e369057
> src/tests/no_executor_framework_test.sh d2d395595b778bc543e1baaa0fd415dc622b647f
> src/tests/script.cpp 515e3141e1d517da4cfc1421d5301d0a3bd6ad51
>
> Diff: https://reviews.apache.org/r/34970/diff/
>
>
> Testing
> -------
>
> The existing no executor framework test picks this up.
>
> Since we do not have an non-zero estimator yet, I modified the slave to send revocable resources in order to manually test the revocable case.
>
>
> Thanks,
>
> Ben Mahler
>
>