You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by zh...@apache.org on 2022/12/08 13:14:00 UTC

[hbase] branch master updated: HBASE-22924 GitHUB PR job should use when clause to filter to just PRs (#4915)

This is an automated email from the ASF dual-hosted git repository.

zhangduo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hbase.git


The following commit(s) were added to refs/heads/master by this push:
     new e1ad781dd9d HBASE-22924 GitHUB PR job should use when clause to filter to just PRs (#4915)
e1ad781dd9d is described below

commit e1ad781dd9ddc201123a63122e22496ee7f8a4b0
Author: Shanky Sharma <sh...@gmail.com>
AuthorDate: Thu Dec 8 18:43:53 2022 +0530

    HBASE-22924 GitHUB PR job should use when clause to filter to just PRs (#4915)
    
    Signed-off-by: Duo Zhang <zh...@apache.org>
---
 dev-support/Jenkinsfile_GitHub                | 12 ++++++++++++
 dev-support/jenkins_precommit_github_yetus.sh |  8 --------
 2 files changed, 12 insertions(+), 8 deletions(-)

diff --git a/dev-support/Jenkinsfile_GitHub b/dev-support/Jenkinsfile_GitHub
index 7e5a9f574d4..bf916903411 100644
--- a/dev-support/Jenkinsfile_GitHub
+++ b/dev-support/Jenkinsfile_GitHub
@@ -92,6 +92,10 @@ pipeline {
                         YETUS_DRIVER = "${WORKDIR}/${YETUS_DRIVER_REL}"
                         ASF_NIGHTLIES_GENERAL_CHECK_BASE="${ASF_NIGHTLIES_BASE}/${WORKDIR_REL}/${PATCH_REL}"
                     }
+                    when {
+                        // this will return true if the pipeline is building a change request, such as a GitHub pull request.
+                        changeRequest()
+                    }
                     steps {
                         dir("${SOURCEDIR}") {
                             checkout scm
@@ -215,6 +219,10 @@ pipeline {
                         YETUS_DRIVER = "${WORKDIR}/${YETUS_DRIVER_REL}"
                         SKIP_ERRORPRONE = true
                     }
+                    when {
+                        // this will return true if the pipeline is building a change request, such as a GitHub pull request.
+                        changeRequest()
+                    }
                     steps {
                         dir("${SOURCEDIR}") {
                             checkout scm
@@ -347,6 +355,10 @@ pipeline {
                         YETUS_DRIVER = "${WORKDIR}/${YETUS_DRIVER_REL}"
                         SKIP_ERRORPRONE = true
                     }
+                    when {
+                        // this will return true if the pipeline is building a change request, such as a GitHub pull request.
+                        changeRequest()
+                    }
                     steps {
                         dir("${SOURCEDIR}") {
                             checkout scm
diff --git a/dev-support/jenkins_precommit_github_yetus.sh b/dev-support/jenkins_precommit_github_yetus.sh
index 8a5fdef94b6..0f5de550f8e 100755
--- a/dev-support/jenkins_precommit_github_yetus.sh
+++ b/dev-support/jenkins_precommit_github_yetus.sh
@@ -67,14 +67,6 @@ mkdir -p "${PATCHDIR}"
 mkdir "${PATCHDIR}/machine"
 "${SOURCEDIR}/dev-support/gather_machine_environment.sh" "${PATCHDIR}/machine"
 
-# If CHANGE_URL is set (e.g., Github Branch Source plugin), process it.
-# Otherwise exit, because we don't want HBase to do a
-# full build.  We wouldn't normally do this check for smaller
-# projects. :)
-if [[ -z "${CHANGE_URL}" ]]; then
-  echo "Full build skipped" > "${PATCHDIR}/report.html"
-  exit 0
-fi
 # enable debug output for yetus
 if [[ "true" = "${DEBUG}" ]]; then
   YETUS_ARGS+=("--debug")