You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Vincent Massol (JIRA)" <ji...@codehaus.org> on 2006/04/08 14:26:48 UTC
[jira] Created: (MINSTALL-18) Bad algorithm to decide if the main
artifact is to be installed or not
Bad algorithm to decide if the main artifact is to be installed or not
----------------------------------------------------------------------
Key: MINSTALL-18
URL: http://jira.codehaus.org/browse/MINSTALL-18
Project: Maven 2.x Install Plugin
Type: Bug
Versions: 2.1
Reporter: Vincent Massol
Here' s what's in InstallMojo's execute method:
{code}
// Here, we have a temporary solution to MINSTALL-3 (isDirectory() is true if it went through compile
// but not package). We are designing in a proper solution for Maven 2.1
if ( file != null && !file.isDirectory() )
{
installer.install( file, artifact, localRepository );
}
else if ( !attachedArtifacts.isEmpty() )
{
getLog().info( "No primary artifact to install, installing attached artifacts instead." );
}
{code}
This fails if we're building a JAR with no sources but with an attached artifact and only the attached artifact is created (this is the case when using the clover plugin). In that case, the install mojo tries to install the main artifact which doesn't exist).
The error is in "!file.isDirectory". In the case of a jar with no sources, this directory will not have been created...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (MINSTALL-18) Bad algorithm to decide if the main
artifact is to be installed or not
Posted by "Wendy Smoak (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MINSTALL-18?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Wendy Smoak updated MINSTALL-18:
--------------------------------
Fix Version/s: (was: 2.3)
This has been scheduled since May 2007 with no activity. Moving it to unscheduled.
> Bad algorithm to decide if the main artifact is to be installed or not
> ----------------------------------------------------------------------
>
> Key: MINSTALL-18
> URL: http://jira.codehaus.org/browse/MINSTALL-18
> Project: Maven 2.x Install Plugin
> Issue Type: Bug
> Affects Versions: 2.1
> Reporter: Vincent Massol
>
> Here' s what's in InstallMojo's execute method:
> {code}
> // Here, we have a temporary solution to MINSTALL-3 (isDirectory() is true if it went through compile
> // but not package). We are designing in a proper solution for Maven 2.1
> if ( file != null && !file.isDirectory() )
> {
> installer.install( file, artifact, localRepository );
> }
> else if ( !attachedArtifacts.isEmpty() )
> {
> getLog().info( "No primary artifact to install, installing attached artifacts instead." );
> }
> {code}
> This fails if we're building a JAR with no sources but with an attached artifact and only the attached artifact is created (this is the case when using the clover plugin). In that case, the install mojo tries to install the main artifact which doesn't exist).
> The error is in "!file.isDirectory". In the case of a jar with no sources, this directory will not have been created...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MINSTALL-18) Bad algorithm to decide if the main
artifact is to be installed or not
Posted by "Stephane Nicoll (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MINSTALL-18?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stephane Nicoll updated MINSTALL-18:
------------------------------------
Fix Version/s: 2.2
> Bad algorithm to decide if the main artifact is to be installed or not
> ----------------------------------------------------------------------
>
> Key: MINSTALL-18
> URL: http://jira.codehaus.org/browse/MINSTALL-18
> Project: Maven 2.x Install Plugin
> Issue Type: Bug
> Affects Versions: 2.1
> Reporter: Vincent Massol
> Fix For: 2.2
>
>
> Here' s what's in InstallMojo's execute method:
> {code}
> // Here, we have a temporary solution to MINSTALL-3 (isDirectory() is true if it went through compile
> // but not package). We are designing in a proper solution for Maven 2.1
> if ( file != null && !file.isDirectory() )
> {
> installer.install( file, artifact, localRepository );
> }
> else if ( !attachedArtifacts.isEmpty() )
> {
> getLog().info( "No primary artifact to install, installing attached artifacts instead." );
> }
> {code}
> This fails if we're building a JAR with no sources but with an attached artifact and only the attached artifact is created (this is the case when using the clover plugin). In that case, the install mojo tries to install the main artifact which doesn't exist).
> The error is in "!file.isDirectory". In the case of a jar with no sources, this directory will not have been created...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MINSTALL-18) Bad algorithm to decide if the main
artifact is to be installed or not
Posted by "Gili (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MINSTALL-18?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=253383#action_253383 ]
Gili commented on MINSTALL-18:
------------------------------
Maven 2.3 doesn't exist. Do you plan on releasing such a version or am I required to use Maven 3.0 to get this fix?
> Bad algorithm to decide if the main artifact is to be installed or not
> ----------------------------------------------------------------------
>
> Key: MINSTALL-18
> URL: http://jira.codehaus.org/browse/MINSTALL-18
> Project: Maven 2.x Install Plugin
> Issue Type: Bug
> Affects Versions: 2.1
> Reporter: Vincent Massol
> Assignee: Benjamin Bentmann
> Fix For: 2.3
>
>
> Here' s what's in InstallMojo's execute method:
> {code}
> // Here, we have a temporary solution to MINSTALL-3 (isDirectory() is true if it went through compile
> // but not package). We are designing in a proper solution for Maven 2.1
> if ( file != null && !file.isDirectory() )
> {
> installer.install( file, artifact, localRepository );
> }
> else if ( !attachedArtifacts.isEmpty() )
> {
> getLog().info( "No primary artifact to install, installing attached artifacts instead." );
> }
> {code}
> This fails if we're building a JAR with no sources but with an attached artifact and only the attached artifact is created (this is the case when using the clover plugin). In that case, the install mojo tries to install the main artifact which doesn't exist).
> The error is in "!file.isDirectory". In the case of a jar with no sources, this directory will not have been created...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MINSTALL-18) Bad algorithm to decide if the main
artifact is to be installed or not
Posted by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MINSTALL-18?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=253390#action_253390 ]
Benjamin Bentmann commented on MINSTALL-18:
-------------------------------------------
Don't confuse Maven (core) with the Maven Install Plugin. This fix is in the Maven Install Plugin, not Maven core.
> Bad algorithm to decide if the main artifact is to be installed or not
> ----------------------------------------------------------------------
>
> Key: MINSTALL-18
> URL: http://jira.codehaus.org/browse/MINSTALL-18
> Project: Maven 2.x Install Plugin
> Issue Type: Bug
> Affects Versions: 2.1
> Reporter: Vincent Massol
> Assignee: Benjamin Bentmann
> Fix For: 2.3
>
>
> Here' s what's in InstallMojo's execute method:
> {code}
> // Here, we have a temporary solution to MINSTALL-3 (isDirectory() is true if it went through compile
> // but not package). We are designing in a proper solution for Maven 2.1
> if ( file != null && !file.isDirectory() )
> {
> installer.install( file, artifact, localRepository );
> }
> else if ( !attachedArtifacts.isEmpty() )
> {
> getLog().info( "No primary artifact to install, installing attached artifacts instead." );
> }
> {code}
> This fails if we're building a JAR with no sources but with an attached artifact and only the attached artifact is created (this is the case when using the clover plugin). In that case, the install mojo tries to install the main artifact which doesn't exist).
> The error is in "!file.isDirectory". In the case of a jar with no sources, this directory will not have been created...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MINSTALL-18) Bad algorithm to decide if the main
artifact is to be installed or not
Posted by "Gili (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MINSTALL-18?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=253402#action_253402 ]
Gili commented on MINSTALL-18:
------------------------------
Makes sense :) Thank you for the clarification!
> Bad algorithm to decide if the main artifact is to be installed or not
> ----------------------------------------------------------------------
>
> Key: MINSTALL-18
> URL: http://jira.codehaus.org/browse/MINSTALL-18
> Project: Maven 2.x Install Plugin
> Issue Type: Bug
> Affects Versions: 2.1
> Reporter: Vincent Massol
> Assignee: Benjamin Bentmann
> Fix For: 2.3
>
>
> Here' s what's in InstallMojo's execute method:
> {code}
> // Here, we have a temporary solution to MINSTALL-3 (isDirectory() is true if it went through compile
> // but not package). We are designing in a proper solution for Maven 2.1
> if ( file != null && !file.isDirectory() )
> {
> installer.install( file, artifact, localRepository );
> }
> else if ( !attachedArtifacts.isEmpty() )
> {
> getLog().info( "No primary artifact to install, installing attached artifacts instead." );
> }
> {code}
> This fails if we're building a JAR with no sources but with an attached artifact and only the attached artifact is created (this is the case when using the clover plugin). In that case, the install mojo tries to install the main artifact which doesn't exist).
> The error is in "!file.isDirectory". In the case of a jar with no sources, this directory will not have been created...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MINSTALL-18) Bad algorithm to decide if the main
artifact is to be installed or not
Posted by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MINSTALL-18?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Bentmann closed MINSTALL-18.
-------------------------------------
Assignee: Benjamin Bentmann
Resolution: Fixed
Fix Version/s: 2.3
Fixed in [r730540|http://svn.eu.apache.org/viewvc?view=rev&revision=730540].
> Bad algorithm to decide if the main artifact is to be installed or not
> ----------------------------------------------------------------------
>
> Key: MINSTALL-18
> URL: http://jira.codehaus.org/browse/MINSTALL-18
> Project: Maven 2.x Install Plugin
> Issue Type: Bug
> Affects Versions: 2.1
> Reporter: Vincent Massol
> Assignee: Benjamin Bentmann
> Fix For: 2.3
>
>
> Here' s what's in InstallMojo's execute method:
> {code}
> // Here, we have a temporary solution to MINSTALL-3 (isDirectory() is true if it went through compile
> // but not package). We are designing in a proper solution for Maven 2.1
> if ( file != null && !file.isDirectory() )
> {
> installer.install( file, artifact, localRepository );
> }
> else if ( !attachedArtifacts.isEmpty() )
> {
> getLog().info( "No primary artifact to install, installing attached artifacts instead." );
> }
> {code}
> This fails if we're building a JAR with no sources but with an attached artifact and only the attached artifact is created (this is the case when using the clover plugin). In that case, the install mojo tries to install the main artifact which doesn't exist).
> The error is in "!file.isDirectory". In the case of a jar with no sources, this directory will not have been created...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MINSTALL-18) Bad algorithm to decide if the main
artifact is to be installed or not
Posted by "Carlos Sanchez (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MINSTALL-18?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carlos Sanchez updated MINSTALL-18:
-----------------------------------
Fix Version/s: (was: 2.2)
2.3
> Bad algorithm to decide if the main artifact is to be installed or not
> ----------------------------------------------------------------------
>
> Key: MINSTALL-18
> URL: http://jira.codehaus.org/browse/MINSTALL-18
> Project: Maven 2.x Install Plugin
> Issue Type: Bug
> Affects Versions: 2.1
> Reporter: Vincent Massol
> Fix For: 2.3
>
>
> Here' s what's in InstallMojo's execute method:
> {code}
> // Here, we have a temporary solution to MINSTALL-3 (isDirectory() is true if it went through compile
> // but not package). We are designing in a proper solution for Maven 2.1
> if ( file != null && !file.isDirectory() )
> {
> installer.install( file, artifact, localRepository );
> }
> else if ( !attachedArtifacts.isEmpty() )
> {
> getLog().info( "No primary artifact to install, installing attached artifacts instead." );
> }
> {code}
> This fails if we're building a JAR with no sources but with an attached artifact and only the attached artifact is created (this is the case when using the clover plugin). In that case, the install mojo tries to install the main artifact which doesn't exist).
> The error is in "!file.isDirectory". In the case of a jar with no sources, this directory will not have been created...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MINSTALL-18) Bad algorithm to decide if the main
artifact is to be installed or not
Posted by "Brian Fox (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MINSTALL-18?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_94881 ]
Brian Fox commented on MINSTALL-18:
-----------------------------------
any chance you have a test case for this?
> Bad algorithm to decide if the main artifact is to be installed or not
> ----------------------------------------------------------------------
>
> Key: MINSTALL-18
> URL: http://jira.codehaus.org/browse/MINSTALL-18
> Project: Maven 2.x Install Plugin
> Issue Type: Bug
> Affects Versions: 2.1
> Reporter: Vincent Massol
> Fix For: 2.2
>
>
> Here' s what's in InstallMojo's execute method:
> {code}
> // Here, we have a temporary solution to MINSTALL-3 (isDirectory() is true if it went through compile
> // but not package). We are designing in a proper solution for Maven 2.1
> if ( file != null && !file.isDirectory() )
> {
> installer.install( file, artifact, localRepository );
> }
> else if ( !attachedArtifacts.isEmpty() )
> {
> getLog().info( "No primary artifact to install, installing attached artifacts instead." );
> }
> {code}
> This fails if we're building a JAR with no sources but with an attached artifact and only the attached artifact is created (this is the case when using the clover plugin). In that case, the install mojo tries to install the main artifact which doesn't exist).
> The error is in "!file.isDirectory". In the case of a jar with no sources, this directory will not have been created...
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira