You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/03/20 10:49:13 UTC

[GitHub] [incubator-shardingsphere] tristaZero opened a new issue #4867: Parse `Top(expression)` query of SQLServer with ANTLR

tristaZero opened a new issue #4867: Parse `Top(expression)` query of SQLServer with ANTLR
URL: https://github.com/apache/incubator-shardingsphere/issues/4867
 
 
   **Content:** To support `Top(expression)` of SQLServer query SQL, the first step is to parse this grammar through Sharding-Parser.
   
   **Difficulty Rating:** : ★★★☆☆

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [shardingsphere] tristaZero commented on issue #4867: Parse `Top(expression)` query of SQLServer with ANTLR

Posted by GitBox <gi...@apache.org>.
tristaZero commented on issue #4867:
URL: https://github.com/apache/shardingsphere/issues/4867#issuecomment-637920580


   @SteNicholas Hi is there any progress?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-shardingsphere] tristaZero commented on issue #4867: Parse `Top(expression)` query of SQLServer with ANTLR

Posted by GitBox <gi...@apache.org>.
tristaZero commented on issue #4867: Parse `Top(expression)` query of SQLServer with ANTLR
URL: https://github.com/apache/incubator-shardingsphere/issues/4867#issuecomment-608213100
 
 
   @SteNicholas 
   Hi, maybe you can try this issue. This task not easy, so it is needed that you split this issue into many little PRs, which will help reduce conflicts with others and help me review it quickly. You can refer to the todo list.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [shardingsphere] tristaZero edited a comment on issue #4867: Parse `Top(expression)` query of SQLServer with ANTLR

Posted by GitBox <gi...@apache.org>.
tristaZero edited a comment on issue #4867:
URL: https://github.com/apache/shardingsphere/issues/4867#issuecomment-601644730


   ### TODO list to handle this issue
   - [x] Correct the `TOP` definition in `DMLStatement.g4` of `SQLServer` referring to [DOC](https://www.sqlservertutorial.net/sql-server-basics/sql-server-select-top/).
   - [x] Add function `visitTop()` of `SQLServerDMLVisitor` to parse out `TopProjectionSegment`
   - [ ] Modify `visitProjection()` of `SQLServerDMLVisitor`
   - [ ] Add parse test cases in `./incubator-shardingsphere/sharding-sql-test/src/main/resources/sql/supported/dml/select-pagination.xml` to check your cod logic.
   - [ ] Check those sql test case[1] are correct or not. 
       * If correct, remove the comments from them, and delete the relative sentences in `isPassedSqlCase()` of `SQLParserParameterizedTest` 
       * If incorrect, revise them, and delete the relative sentences in `isPassedSqlCase()` of `SQLParserParameterizedTest` 
   - [ ] Modify the corresponding parsed results in [2] to make `SQLParserParameterizedTest` run well.
   
   [1] All the SQL cases containing `TOP` located in `./incubator-shardingsphere/sharding-sql-test/src/main/resources/sql/supported/dml/select-pagination.xml` and `./incubator-shardingsphere/sharding-sql-test/src/main/resources/sql/supported/dml/select-pagination-group-by-order-by.xml`
   
   [2] ./incubator-shardingsphere/sharding-sql-test/src/main/resources/sql/supported


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-shardingsphere] tristaZero edited a comment on issue #4867: Parse `Top(expression)` query of SQLServer with ANTLR

Posted by GitBox <gi...@apache.org>.
tristaZero edited a comment on issue #4867: Parse `Top(expression)` query of SQLServer with ANTLR
URL: https://github.com/apache/incubator-shardingsphere/issues/4867#issuecomment-601644730
 
 
   ### TODO list to handle this issue
   - [ ] Correct the `TOP` definition in `DMLStatement.g4` of `SQLServer` referring to [DOC](https://www.sqlservertutorial.net/sql-server-basics/sql-server-select-top/).
   - [ ] Add function `visitTop()` of `SQLServerDMLVisitor` to parse out `TopProjectionSegment`
   - [ ] Modify `visitProjection()` of `SQLServerDMLVisitor`
   - [ ] Add parse test cases in `./incubator-shardingsphere/sharding-sql-test/src/main/resources/sql/supported/dml/select-pagination.xml` to check your cod logic.
   - [ ] Check those sql test case[1] are correct or not. 
       * If correct, remove the comments from them, and delete the relative sentences in `isPassedSqlCase()` of `SQLParserParameterizedTest` 
       * If incorrect, revise them, and delete the relative sentences in `isPassedSqlCase()` of `SQLParserParameterizedTest` 
   - [ ] Modify the corresponding parsed results in [2] to make `SQLParserParameterizedTest` run well.
   
   [1] All the SQL cases containing `TOP` located in `./incubator-shardingsphere/sharding-sql-test/src/main/resources/sql/supported/dml/select-pagination.xml` and `./incubator-shardingsphere/sharding-sql-test/src/main/resources/sql/supported/dml/select-pagination-group-by-order-by.xml`
   
   [2] ./incubator-shardingsphere/sharding-sql-test/src/main/resources/sql/supported

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [shardingsphere] strongduanmu commented on issue #4867: Parse `Top(expression)` query of SQLServer with ANTLR

Posted by GitBox <gi...@apache.org>.
strongduanmu commented on issue #4867:
URL: https://github.com/apache/shardingsphere/issues/4867#issuecomment-650558695


   @tristaZero The 1-3 sub-tasks of this issue have been completed by @SteNicholas, and I will be responsible for the remaining three 4-6 sub-tasks.😊


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero commented on issue #4867: Parse `Top(expression)` query of SQLServer with ANTLR

Posted by GitBox <gi...@apache.org>.
tristaZero commented on issue #4867:
URL: https://github.com/apache/shardingsphere/issues/4867#issuecomment-641794921


   @SteNicholas #5782 is duplicate with this one. This feature is in high demand. Hope see it finished ASAP.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero closed issue #4867: Parse `Top(expression)` query of SQLServer with ANTLR

Posted by GitBox <gi...@apache.org>.
tristaZero closed issue #4867:
URL: https://github.com/apache/shardingsphere/issues/4867


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero edited a comment on issue #4867: Parse `Top(expression)` query of SQLServer with ANTLR

Posted by GitBox <gi...@apache.org>.
tristaZero edited a comment on issue #4867:
URL: https://github.com/apache/shardingsphere/issues/4867#issuecomment-601644730


   ### TODO list to handle this issue
   - [x] Correct the `TOP` definition in `DMLStatement.g4` of `SQLServer` referring to [DOC](https://www.sqlservertutorial.net/sql-server-basics/sql-server-select-top/).
   - [x] Add function `visitTop()` of `SQLServerDMLVisitor` to parse out `TopProjectionSegment`
   - [x] Modify `visitProjection()` of `SQLServerDMLVisitor`
   - [ ] Add parse test cases in `./incubator-shardingsphere/sharding-sql-test/src/main/resources/sql/supported/dml/select-pagination.xml` to check your cod logic.
   - [ ] Check those sql test case[1] are correct or not. 
       * If correct, remove the comments from them, and delete the relative sentences in `isPassedSqlCase()` of `SQLParserParameterizedTest` 
       * If incorrect, revise them, and delete the relative sentences in `isPassedSqlCase()` of `SQLParserParameterizedTest` 
   - [ ] Modify the corresponding parsed results in [2] to make `SQLParserParameterizedTest` run well.
   
   [1] All the SQL cases containing `TOP` located in `./incubator-shardingsphere/sharding-sql-test/src/main/resources/sql/supported/dml/select-pagination.xml` and `./incubator-shardingsphere/sharding-sql-test/src/main/resources/sql/supported/dml/select-pagination-group-by-order-by.xml`
   
   [2] ./incubator-shardingsphere/sharding-sql-test/src/main/resources/sql/supported


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero commented on issue #4867: Parse `Top(expression)` query of SQLServer with ANTLR

Posted by GitBox <gi...@apache.org>.
tristaZero commented on issue #4867:
URL: https://github.com/apache/shardingsphere/issues/4867#issuecomment-629936417


   Hi, @SteNicholas  is there any progress during the past month?  I believe you are working hard on it, but my suggestion is to split this massive PR into small ones, which can make the community know how it is going. :-）
   
   Best,
   Trista


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-shardingsphere] tristaZero commented on issue #4867: Parse `Top(expression)` query of SQLServer with ANTLR

Posted by GitBox <gi...@apache.org>.
tristaZero commented on issue #4867: Parse `Top(expression)` query of SQLServer with ANTLR
URL: https://github.com/apache/incubator-shardingsphere/issues/4867#issuecomment-602170870
 
 
   The prerequisite Issue of this one is #4885

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [shardingsphere] tristaZero removed a comment on issue #4867: Parse `Top(expression)` query of SQLServer with ANTLR

Posted by GitBox <gi...@apache.org>.
tristaZero removed a comment on issue #4867:
URL: https://github.com/apache/shardingsphere/issues/4867#issuecomment-637920580






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-shardingsphere] tristaZero commented on issue #4867: Parse `Top(expression)` query of SQLServer with ANTLR

Posted by GitBox <gi...@apache.org>.
tristaZero commented on issue #4867: Parse `Top(expression)` query of SQLServer with ANTLR
URL: https://github.com/apache/incubator-shardingsphere/issues/4867#issuecomment-601644730
 
 
   ### TODO list to handle this issue
   - [ ] Correct the `TOP` definition in `DMLStatement.g4` of `SQLServer` referring to [DOC](https://www.sqlservertutorial.net/sql-server-basics/sql-server-select-top/).
   - [ ] Add function `visitTop()` of `SQLServerDMLVisitor` to parse out `TopProjectionSegment`
   - [ ] Modify `visitProjection()` of `SQLServerDMLVisitor`
   - [ ] Check those sql test case[1] are correct or not. 
       * If correct, remove the comments from them, and delete the relative sentences in `isPassedSqlCase()` of `SQLParserParameterizedTest` 
       * If incorrect, revise them, and delete the relative sentences in `isPassedSqlCase()` of `SQLParserParameterizedTest` 
   - [ ] Modify the corresponding parsed results in [2] to make `SQLParserParameterizedTest` run well.
   
   [1] All the SQL cases containing `TOP` located in `./incubator-shardingsphere/sharding-sql-test/src/main/resources/sql/supported/dml/select-pagination.xml` and `./incubator-shardingsphere/sharding-sql-test/src/main/resources/sql/supported/dml/select-pagination-group-by-order-by.xml`
   
   [2] ./incubator-shardingsphere/sharding-sql-test/src/main/resources/sql/supported

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services