You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by pe...@apache.org on 2020/09/03 08:36:26 UTC
[pulsar] branch master updated: Replace if..else with switch in
TypeMessageBuilderImpl (#7947)
This is an automated email from the ASF dual-hosted git repository.
penghui pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new 7e4ace2 Replace if..else with switch in TypeMessageBuilderImpl (#7947)
7e4ace2 is described below
commit 7e4ace21fc76e2219791e8904e41f79e5cdaf83e
Author: Aloys <lo...@gmail.com>
AuthorDate: Thu Sep 3 16:36:09 2020 +0800
Replace if..else with switch in TypeMessageBuilderImpl (#7947)
---
.../client/impl/TypedMessageBuilderImpl.java | 51 +++++++++++++---------
1 file changed, 30 insertions(+), 21 deletions(-)
diff --git a/pulsar-client/src/main/java/org/apache/pulsar/client/impl/TypedMessageBuilderImpl.java b/pulsar-client/src/main/java/org/apache/pulsar/client/impl/TypedMessageBuilderImpl.java
index b6a85e5..966d932 100644
--- a/pulsar-client/src/main/java/org/apache/pulsar/client/impl/TypedMessageBuilderImpl.java
+++ b/pulsar-client/src/main/java/org/apache/pulsar/client/impl/TypedMessageBuilderImpl.java
@@ -236,27 +236,36 @@ public class TypedMessageBuilderImpl<T> implements TypedMessageBuilder<T> {
@Override
public TypedMessageBuilder<T> loadConf(Map<String, Object> config) {
config.forEach((key, value) -> {
- if (key.equals(CONF_KEY)) {
- this.key(checkType(value, String.class));
- } else if (key.equals(CONF_PROPERTIES)) {
- this.properties(checkType(value, Map.class));
- } else if (key.equals(CONF_EVENT_TIME)) {
- this.eventTime(checkType(value, Long.class));
- } else if (key.equals(CONF_SEQUENCE_ID)) {
- this.sequenceId(checkType(value, Long.class));
- } else if (key.equals(CONF_REPLICATION_CLUSTERS)) {
- this.replicationClusters(checkType(value, List.class));
- } else if (key.equals(CONF_DISABLE_REPLICATION)) {
- boolean disableReplication = checkType(value, Boolean.class);
- if (disableReplication) {
- this.disableReplication();
- }
- } else if (key.equals(CONF_DELIVERY_AFTER_SECONDS)) {
- this.deliverAfter(checkType(value, Long.class), TimeUnit.SECONDS);
- } else if (key.equals(CONF_DELIVERY_AT)) {
- this.deliverAt(checkType(value, Long.class));
- } else {
- throw new RuntimeException("Invalid message config key '" + key + "'");
+ switch (key) {
+ case CONF_KEY:
+ this.key(checkType(value, String.class));
+ break;
+ case CONF_PROPERTIES:
+ this.properties(checkType(value, Map.class));
+ break;
+ case CONF_EVENT_TIME:
+ this.eventTime(checkType(value, Long.class));
+ break;
+ case CONF_SEQUENCE_ID:
+ this.sequenceId(checkType(value, Long.class));
+ break;
+ case CONF_REPLICATION_CLUSTERS:
+ this.replicationClusters(checkType(value, List.class));
+ break;
+ case CONF_DISABLE_REPLICATION:
+ boolean disableReplication = checkType(value, Boolean.class);
+ if (disableReplication) {
+ this.disableReplication();
+ }
+ break;
+ case CONF_DELIVERY_AFTER_SECONDS:
+ this.deliverAfter(checkType(value, Long.class), TimeUnit.SECONDS);
+ break;
+ case CONF_DELIVERY_AT:
+ this.deliverAt(checkType(value, Long.class));
+ break;
+ default:
+ throw new RuntimeException("Invalid message config key '" + key + "'");
}
});
return this;