[jira] [Commented] (TAP5-1483) AssetPathConstructorImpl should use BaseURLSource

["Howard M. Lewis Ship (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TAP5-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13130775#comment-13130775 ] 

Howard M. Lewis Ship commented on TAP5-1483:
--------------------------------------------

Since this is behavior that most people will not want, I think it will need to be configurable, and default off.
                
> AssetPathConstructorImpl should use BaseURLSource
> -------------------------------------------------
>
>                 Key: TAP5-1483
>                 URL: https://issues.apache.org/jira/browse/TAP5-1483
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.2.4
>            Reporter: Jonathan Barker
>            Priority: Minor
>         Attachments: patch.txt
>
>
> Asset paths should be constructed using the BaseURLSource rather than just the request context path to match the behavior for pages, etc.  Currently, to get absolute URL's including domain portion for assets, you need to override the AssetPathConstructor.
> Apart from contributing the BaseURLSource, it is a small change from:
>         StringBuilder builder = new StringBuilder(request.getContextPath());
> to
>         StringBuilder builder = new StringBuilder(baseURLSource.getBaseURL(request.isSecure()));
>         builder.append(request.getContextPath());
>  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira