You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Carsten Ziegeler (JIRA)" <ji...@apache.org> on 2010/03/09 15:04:27 UTC

[jira] Created: (SLING-1431) Utility method to get the service ranking

Utility method to get the service ranking
-----------------------------------------

                 Key: SLING-1431
                 URL: https://issues.apache.org/jira/browse/SLING-1431
             Project: Sling
          Issue Type: Improvement
          Components: Commons
    Affects Versions: Commons OSGi 2.0.4
            Reporter: Carsten Ziegeler
            Assignee: Carsten Ziegeler
             Fix For: Commons OSGi 2.0.6


The service ranking property is optional, if it is not specified or not of type integer, the ranking is 0

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SLING-1431) Utility method to get the service ranking

Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SLING-1431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12843239#action_12843239 ] 

Carsten Ziegeler commented on SLING-1431:
-----------------------------------------

> Shouldn't the equals and hashCode methods also be implemented ?
Yes, that would be my next commit :)

With Comparable you can already sort lists :)

> Utility method to get the service ranking
> -----------------------------------------
>
>                 Key: SLING-1431
>                 URL: https://issues.apache.org/jira/browse/SLING-1431
>             Project: Sling
>          Issue Type: Improvement
>          Components: Commons
>    Affects Versions: Commons OSGi 2.0.4
>            Reporter: Carsten Ziegeler
>            Assignee: Carsten Ziegeler
>             Fix For: Commons OSGi 2.0.6
>
>
> The service ranking property is optional, if it is not specified or not of type integer, the ranking is 0

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (SLING-1431) Utility method to get the service ranking

Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SLING-1431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Carsten Ziegeler closed SLING-1431.
-----------------------------------


> Utility method to get the service ranking
> -----------------------------------------
>
>                 Key: SLING-1431
>                 URL: https://issues.apache.org/jira/browse/SLING-1431
>             Project: Sling
>          Issue Type: Improvement
>          Components: Commons
>    Affects Versions: Commons OSGi 2.0.4
>            Reporter: Carsten Ziegeler
>            Assignee: Carsten Ziegeler
>             Fix For: Commons OSGi 2.0.6
>
>
> The service ranking property is optional, if it is not specified or not of type integer, the ranking is 0

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (SLING-1431) Utility method to get the service ranking

Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SLING-1431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Carsten Ziegeler resolved SLING-1431.
-------------------------------------

    Resolution: Fixed

I think the implementation is fine now

> Utility method to get the service ranking
> -----------------------------------------
>
>                 Key: SLING-1431
>                 URL: https://issues.apache.org/jira/browse/SLING-1431
>             Project: Sling
>          Issue Type: Improvement
>          Components: Commons
>    Affects Versions: Commons OSGi 2.0.4
>            Reporter: Carsten Ziegeler
>            Assignee: Carsten Ziegeler
>             Fix For: Commons OSGi 2.0.6
>
>
> The service ranking property is optional, if it is not specified or not of type integer, the ranking is 0

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (SLING-1431) Utility method to get the service ranking

Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SLING-1431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Carsten Ziegeler resolved SLING-1431.
-------------------------------------

    Resolution: Fixed

Adding in revision 920882 together with a test case

> Utility method to get the service ranking
> -----------------------------------------
>
>                 Key: SLING-1431
>                 URL: https://issues.apache.org/jira/browse/SLING-1431
>             Project: Sling
>          Issue Type: Improvement
>          Components: Commons
>    Affects Versions: Commons OSGi 2.0.4
>            Reporter: Carsten Ziegeler
>            Assignee: Carsten Ziegeler
>             Fix For: Commons OSGi 2.0.6
>
>
> The service ranking property is optional, if it is not specified or not of type integer, the ranking is 0

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SLING-1431) Utility method to get the service ranking

Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SLING-1431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12843231#action_12843231 ] 

Felix Meschberger commented on SLING-1431:
------------------------------------------

Some notes:

  Shouldn't the equals and hashCode methods also be implemented ?

  Why not implementing the Comparator interface, which could then be used to sort lists of maps or as the Comparator for TreeSet/Map ?

> Utility method to get the service ranking
> -----------------------------------------
>
>                 Key: SLING-1431
>                 URL: https://issues.apache.org/jira/browse/SLING-1431
>             Project: Sling
>          Issue Type: Improvement
>          Components: Commons
>    Affects Versions: Commons OSGi 2.0.4
>            Reporter: Carsten Ziegeler
>            Assignee: Carsten Ziegeler
>             Fix For: Commons OSGi 2.0.6
>
>
> The service ranking property is optional, if it is not specified or not of type integer, the ranking is 0

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Reopened: (SLING-1431) Utility method to get the service ranking

Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SLING-1431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Carsten Ziegeler reopened SLING-1431:
-------------------------------------


Instead of just getting the ranking, it's more convenient to get a comparable object which acts like ServiceReference#compareTo

> Utility method to get the service ranking
> -----------------------------------------
>
>                 Key: SLING-1431
>                 URL: https://issues.apache.org/jira/browse/SLING-1431
>             Project: Sling
>          Issue Type: Improvement
>          Components: Commons
>    Affects Versions: Commons OSGi 2.0.4
>            Reporter: Carsten Ziegeler
>            Assignee: Carsten Ziegeler
>             Fix For: Commons OSGi 2.0.6
>
>
> The service ranking property is optional, if it is not specified or not of type integer, the ranking is 0

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.