You are viewing a plain text version of this content. The canonical link for it is here.
Posted to slide-dev@jakarta.apache.org by Fabrice Dewasmes <fa...@openwide.fr> on 2005/10/21 15:49:46 UTC
BUG in versioning helper
Please correct me if I'm wrong but it seems that versioning helper
suffers from a little bug in the update method. The webDAV spec mentions
that all dead properties of previous VR should be copied to VCR in case
of uncheckout. So a call is made to update from the uncheckout method.
The comments say that the dead properties are being copied from VR to
VCR but the code "says" something else. Please see proposed patch for
this and tell me if I'm wrong. For me this bug as been introduced when
ResourceKind were introduced.
If things are OK I can file this in bugzilla and post patch.
However, i'd lik eto mention that it's the fourth patch I submit since a
few months and none of them have been integrated...... Again, I'm a bit
worried about slide dev team, is it still alive ?
Fabrice
Index: VersioningHelper.java
===================================================================
RCS file: /home/cvspublic/jakarta-slide/src/webdav/server/org/apache/slide/webdav/util/VersioningHelper.java,v
retrieving revision 1.118
*diff -u -r1.118 VersioningHelper.java*
*--- VersioningHelper.java 25 Feb 2005 16:57:55 -0000 1.118*
*+++ VersioningHelper.java 21 Oct 2005 13:39:38 -0000*
@@ -1578,7 +1578,7 @@
while (propertyEnum.hasMoreElements()) {
NodeProperty p = (NodeProperty)propertyEnum.nextElement();
//if( !p.isLiveProperty() ) {
- if (resourceKind.isSupportedLiveProperty(p.getPropertyName())) {
+ if (!resourceKind.isSupportedLiveProperty(p.getPropertyName())) {
vcrRevisionDescriptor.setProperty(p);
}
}
--
Fabrice Dewasmes
Responsable du domaine urbanisation des systèmes d'information
fabrice.dewasmes@openwide.fr
06.89.88.65.37
--
Open Wide
14 rue Gaillon
75002 PARIS
www.openwide.fr
---------------------------------------------------------------------
To unsubscribe, e-mail: slide-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: slide-dev-help@jakarta.apache.org
Re: BUG in versioning helper
Posted by Carlos Villegas <ca...@uniscope.jp>.
Unfortunately, in my case, I've been busy with other things and I
haven't been able to help for a long time. It seems all the other
comitters are busy as well or have other interests at the moment!
However, I'll might need Slide in one of my company projects during the
following months, so I may be able to contribute again.
Please, make sure all your patches and bug reports are in bugzilla,
since I won't have time to go through the list archive. I'll try to
commit at least the obvious stuff like this one.
Carlos
Fabrice Dewasmes wrote:
> Please correct me if I'm wrong but it seems that versioning helper
> suffers from a little bug in the update method. The webDAV spec mentions
> that all dead properties of previous VR should be copied to VCR in case
> of uncheckout. So a call is made to update from the uncheckout method.
> The comments say that the dead properties are being copied from VR to
> VCR but the code "says" something else. Please see proposed patch for
> this and tell me if I'm wrong. For me this bug as been introduced when
> ResourceKind were introduced.
>
> If things are OK I can file this in bugzilla and post patch.
>
> However, i'd lik eto mention that it's the fourth patch I submit since a
> few months and none of them have been integrated...... Again, I'm a bit
> worried about slide dev team, is it still alive ?
>
> Fabrice
>
> Index: VersioningHelper.java
> ===================================================================
> RCS file:
> /home/cvspublic/jakarta-slide/src/webdav/server/org/apache/slide/webdav/util/VersioningHelper.java,v
>
> retrieving revision 1.118
> *diff -u -r1.118 VersioningHelper.java*
> *--- VersioningHelper.java 25 Feb 2005 16:57:55 -0000 1.118*
> *+++ VersioningHelper.java 21 Oct 2005 13:39:38 -0000*
> @@ -1578,7 +1578,7 @@
> while (propertyEnum.hasMoreElements()) {
> NodeProperty p = (NodeProperty)propertyEnum.nextElement();
> //if( !p.isLiveProperty() ) {
> - if
> (resourceKind.isSupportedLiveProperty(p.getPropertyName())) {
> + if
> (!resourceKind.isSupportedLiveProperty(p.getPropertyName())) {
> vcrRevisionDescriptor.setProperty(p);
> }
> }
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: slide-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: slide-dev-help@jakarta.apache.org