You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2020/05/18 13:26:41 UTC

[commons-codec] branch master updated (1be7a57 -> a887bc1)

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/commons-codec.git.


    from 1be7a57  Download animal-sniffer for use with Java 7
     new 913efdf  Update tests from JUnit 4.12 to 4.13.
     new 6333e50  Javadoc.
     new 5b2b313  Javadoc: Close HTML tags.
     new 38f7f12  Reuse constructor.
     new d9d80a6  No need for local var.
     new a887bc1  Merge branch 'master' of https://gitbox.apache.org/repos/asf/commons-codec

The 6 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 pom.xml                                                        |  2 +-
 src/changes/changes.xml                                        |  1 +
 src/main/java/org/apache/commons/codec/net/BCodec.java         |  5 +++--
 src/main/java/org/apache/commons/codec/net/QCodec.java         |  2 ++
 .../org/apache/commons/codec/net/QuotedPrintableCodec.java     | 10 ++++++++--
 src/main/java/org/apache/commons/codec/net/RFC1522Codec.java   |  5 +++--
 src/main/java/org/apache/commons/codec/net/URLCodec.java       |  4 +++-
 7 files changed, 21 insertions(+), 8 deletions(-)


[commons-codec] 05/06: No need for local var.

Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-codec.git

commit d9d80a61b3a432592c9413ee2fd8680704cd1eb0
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Mon May 18 09:26:12 2020 -0400

    No need for local var.
---
 src/main/java/org/apache/commons/codec/net/RFC1522Codec.java | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/main/java/org/apache/commons/codec/net/RFC1522Codec.java b/src/main/java/org/apache/commons/codec/net/RFC1522Codec.java
index 1d326b0..90564fe 100644
--- a/src/main/java/org/apache/commons/codec/net/RFC1522Codec.java
+++ b/src/main/java/org/apache/commons/codec/net/RFC1522Codec.java
@@ -76,8 +76,7 @@ abstract class RFC1522Codec {
         buffer.append(SEP);
         buffer.append(this.getEncoding());
         buffer.append(SEP);
-        final byte [] rawData = this.doEncoding(text.getBytes(charset));
-        buffer.append(StringUtils.newStringUsAscii(rawData));
+        buffer.append(StringUtils.newStringUsAscii(this.doEncoding(text.getBytes(charset))));
         buffer.append(POSTFIX);
         return buffer.toString();
     }


[commons-codec] 04/06: Reuse constructor.

Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-codec.git

commit 38f7f12d20a32279823c0870be6238932e06fdcb
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Mon May 18 09:24:00 2020 -0400

    Reuse constructor.
---
 src/main/java/org/apache/commons/codec/net/BCodec.java | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/main/java/org/apache/commons/codec/net/BCodec.java b/src/main/java/org/apache/commons/codec/net/BCodec.java
index 06eda58..46263c2 100644
--- a/src/main/java/org/apache/commons/codec/net/BCodec.java
+++ b/src/main/java/org/apache/commons/codec/net/BCodec.java
@@ -81,8 +81,7 @@ public class BCodec extends RFC1522Codec implements StringEncoder, StringDecoder
      * @since 1.7
      */
     public BCodec(final Charset charset) {
-        this.charset = charset;
-        this.decodingPolicy = DECODING_POLICY_DEFAULT;
+        this(charset, DECODING_POLICY_DEFAULT);
     }
 
     /**


[commons-codec] 01/06: Update tests from JUnit 4.12 to 4.13.

Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-codec.git

commit 913efdf10e8e9083cda9a3feb35dcd1f0d8c5c2e
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Mon May 18 09:10:40 2020 -0400

    Update tests from JUnit 4.12 to 4.13.
---
 pom.xml                 | 2 +-
 src/changes/changes.xml | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index 4020810..b1673d8 100644
--- a/pom.xml
+++ b/pom.xml
@@ -213,7 +213,7 @@ limitations under the License.
     <dependency>
       <groupId>junit</groupId>
       <artifactId>junit</artifactId>
-      <version>4.12</version>
+      <version>4.13</version>
       <scope>test</scope>
     </dependency>
     <dependency>
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index 5fc223b..aa1c69e 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -46,6 +46,7 @@ The <action> type attribute can be add,update,fix,remove.
       <action issue="CODEC-264" dev="aherbert" due-to="Andy Seaborne" type="fix">MurmurHash3: Ensure hash128 maintains the sign extension bug.</action>
       <action issue="CODEC-280" dev="aherbert" type="update">Base32/Base64/BCodec: Added strict decoding property to control handling of trailing bits. Default lenient mode discards them without error. Strict mode raise an exception.</action>
       <action issue="CODEC-289" dev="aherbert" type="update">Base32/Base64 Input/OutputStream: Added strict decoding property to control handling of trailing bits. Default lenient mode discards them without error. Strict mode raise an exception.</action>
+      <action                   dev="ggregory" type="update" due-to="Gary Gregory">Update tests from JUnit 4.12 to 4.13.</action>
     </release>
 
     <release version="1.14" date="2019-12-30" description="Feature and fix release.">


[commons-codec] 03/06: Javadoc: Close HTML tags.

Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-codec.git

commit 5b2b313b67cf5b6e79f9600e3f014d95c7f08ae5
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Mon May 18 09:19:32 2020 -0400

    Javadoc: Close HTML tags.
---
 src/main/java/org/apache/commons/codec/net/BCodec.java         |  2 ++
 src/main/java/org/apache/commons/codec/net/QCodec.java         |  2 ++
 .../org/apache/commons/codec/net/QuotedPrintableCodec.java     | 10 ++++++++--
 src/main/java/org/apache/commons/codec/net/URLCodec.java       |  4 +++-
 4 files changed, 15 insertions(+), 3 deletions(-)

diff --git a/src/main/java/org/apache/commons/codec/net/BCodec.java b/src/main/java/org/apache/commons/codec/net/BCodec.java
index e9f9ecc..06eda58 100644
--- a/src/main/java/org/apache/commons/codec/net/BCodec.java
+++ b/src/main/java/org/apache/commons/codec/net/BCodec.java
@@ -36,8 +36,10 @@ import org.apache.commons.codec.binary.BaseNCodec;
  * <a href="http://www.ietf.org/rfc/rfc1522.txt">RFC 1522</a> describes techniques to allow the encoding of non-ASCII
  * text in various portions of a RFC 822 [2] message header, in a manner which is unlikely to confuse existing message
  * handling software.
+ * </p>
  * <p>
  * This class is immutable and thread-safe.
+ * </p>
  *
  * @see <a href="http://www.ietf.org/rfc/rfc1522.txt">MIME (Multipurpose Internet Mail Extensions) Part Two: Message
  *          Header Extensions for Non-ASCII Text</a>
diff --git a/src/main/java/org/apache/commons/codec/net/QCodec.java b/src/main/java/org/apache/commons/codec/net/QCodec.java
index 86d4a50..3098f60 100644
--- a/src/main/java/org/apache/commons/codec/net/QCodec.java
+++ b/src/main/java/org/apache/commons/codec/net/QCodec.java
@@ -35,6 +35,7 @@ import org.apache.commons.codec.StringEncoder;
  * <a href="http://www.ietf.org/rfc/rfc1522.txt">RFC 1522</a> describes techniques to allow the encoding of non-ASCII
  * text in various portions of a RFC 822 [2] message header, in a manner which is unlikely to confuse existing message
  * handling software.
+ * </p>
  * <p>
  * This class is conditionally thread-safe.
  * The instance field for encoding blanks is mutable {@link #setEncodeBlanks(boolean)}
@@ -42,6 +43,7 @@ import org.apache.commons.codec.StringEncoder;
  * If an instance of the class is shared between threads, the caller needs to ensure that suitable synchronisation
  * is used to ensure safe publication of the value between threads, and must not invoke
  * {@link #setEncodeBlanks(boolean)} after initial setup.
+ * </p>
  *
  * @see <a href="http://www.ietf.org/rfc/rfc1522.txt">MIME (Multipurpose Internet Mail Extensions) Part Two: Message
  *          Header Extensions for Non-ASCII Text</a>
diff --git a/src/main/java/org/apache/commons/codec/net/QuotedPrintableCodec.java b/src/main/java/org/apache/commons/codec/net/QuotedPrintableCodec.java
index 0a99bb1..e18b298 100644
--- a/src/main/java/org/apache/commons/codec/net/QuotedPrintableCodec.java
+++ b/src/main/java/org/apache/commons/codec/net/QuotedPrintableCodec.java
@@ -42,20 +42,26 @@ import org.apache.commons.codec.binary.StringUtils;
  * data remains largely recognizable by humans. A body which is entirely ASCII may also be encoded in Quoted-Printable
  * to ensure the integrity of the data should the message pass through a character- translating, and/or line-wrapping
  * gateway.
+ * </p>
  * <p>
  * Note:
+ * </p>
  * <p>
  * Depending on the selected {@code strict} parameter, this class will implement a different set of rules of the
  * quoted-printable spec:
+ * </p>
  * <ul>
- *   <li>{@code strict=false}: only rules #1 and #2 are implemented
- *   <li>{@code strict=true}: all rules #1 through #5 are implemented
+ *   <li>{@code strict=false}: only rules #1 and #2 are implemented</li>
+ *   <li>{@code strict=true}: all rules #1 through #5 are implemented</li>
  * </ul>
+ * <p>
  * Originally, this class only supported the non-strict mode, but the codec in this partial form could already be used
  * for certain applications that do not require quoted-printable line formatting (rules #3, #4, #5), for instance
  * Q codec. The strict mode has been added in 1.10.
+ * </p>
  * <p>
  * This class is immutable and thread-safe.
+ * </p>
  *
  * @see <a href="http://www.ietf.org/rfc/rfc1521.txt">RFC 1521 MIME (Multipurpose Internet Mail Extensions) Part One:
  *          Mechanisms for Specifying and Describing the Format of Internet Message Bodies </a>
diff --git a/src/main/java/org/apache/commons/codec/net/URLCodec.java b/src/main/java/org/apache/commons/codec/net/URLCodec.java
index 2d3f9f5..07a3e25 100644
--- a/src/main/java/org/apache/commons/codec/net/URLCodec.java
+++ b/src/main/java/org/apache/commons/codec/net/URLCodec.java
@@ -36,8 +36,10 @@ import org.apache.commons.codec.binary.StringUtils;
  * This codec is meant to be a replacement for standard Java classes {@link java.net.URLEncoder} and
  * {@link java.net.URLDecoder} on older Java platforms, as these classes in Java versions below
  * 1.4 rely on the platform's default charset encoding.
+ * </p>
  * <p>
- * This class is thread-safe since 1.11
+ * This class is thread-safe as of 1.11
+ * </p>
  *
  * @see <a href="http://www.w3.org/TR/html4/interact/forms.html#h-17.13.4.1">Chapter 17.13.4 Form content types</a>
  *           of the <a href="http://www.w3.org/TR/html4/">HTML 4.01 Specification</a>


[commons-codec] 06/06: Merge branch 'master' of https://gitbox.apache.org/repos/asf/commons-codec

Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-codec.git

commit a887bc142acc791fd9342ee5935961e0852959e8
Merge: d9d80a6 1be7a57
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Mon May 18 09:26:19 2020 -0400

    Merge branch 'master' of https://gitbox.apache.org/repos/asf/commons-codec

 pom.xml | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)



[commons-codec] 02/06: Javadoc.

Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-codec.git

commit 6333e5048aa77fd6472d857717e3be71576ebc20
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Mon May 18 09:12:45 2020 -0400

    Javadoc.
---
 src/main/java/org/apache/commons/codec/net/RFC1522Codec.java | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/main/java/org/apache/commons/codec/net/RFC1522Codec.java b/src/main/java/org/apache/commons/codec/net/RFC1522Codec.java
index f1e892a..1d326b0 100644
--- a/src/main/java/org/apache/commons/codec/net/RFC1522Codec.java
+++ b/src/main/java/org/apache/commons/codec/net/RFC1522Codec.java
@@ -30,8 +30,10 @@ import org.apache.commons.codec.binary.StringUtils;
  * <a href="http://www.ietf.org/rfc/rfc1522.txt">RFC 1522</a> describes techniques to allow the
  * encoding of non-ASCII text in various portions of a RFC 822 [2] message header, in a manner which
  * is unlikely to confuse existing message handling software.
+ * </p>
  * <p>
  * This class is immutable and thread-safe.
+ * </p>
  *
  * @see <a href="http://www.ietf.org/rfc/rfc1522.txt">MIME (Multipurpose Internet Mail Extensions) Part Two:
  *          Message Header Extensions for Non-ASCII Text</a>