You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/01/22 07:47:00 UTC
[GitHub] [hadoop-ozone] xiaoyuyao opened a new pull request #478: HDDS-2924.
Fix Pipeline#nodeIdsHash collision issue.
xiaoyuyao opened a new pull request #478: HDDS-2924. Fix Pipeline#nodeIdsHash collision issue.
URL: https://github.com/apache/hadoop-ozone/pull/478
## What changes were proposed in this pull request?
Change to use the set of datanodes that form the pipeline to detect overlapped pipeline allocation.
Remove the nodeIdHash that could collide.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-2924
## How was this patch tested?
unit tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] xiaoyuyao commented on issue #478: HDDS-2924. Fix
Pipeline#nodeIdsHash collision issue.
Posted by GitBox <gi...@apache.org>.
xiaoyuyao commented on issue #478: HDDS-2924. Fix Pipeline#nodeIdsHash collision issue.
URL: https://github.com/apache/hadoop-ozone/pull/478#issuecomment-578905385
push the correct rebase.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] xiaoyuyao commented on issue #478: HDDS-2924. Fix
Pipeline#nodeIdsHash collision issue.
Posted by GitBox <gi...@apache.org>.
xiaoyuyao commented on issue #478: HDDS-2924. Fix Pipeline#nodeIdsHash collision issue.
URL: https://github.com/apache/hadoop-ozone/pull/478#issuecomment-578886072
/retest after rebase on github
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] xiaoyuyao commented on issue #478: HDDS-2924. Fix
Pipeline#nodeIdsHash collision issue.
Posted by GitBox <gi...@apache.org>.
xiaoyuyao commented on issue #478: HDDS-2924. Fix Pipeline#nodeIdsHash collision issue.
URL: https://github.com/apache/hadoop-ozone/pull/478#issuecomment-578942979
Thanks @anuengineer and @timmylicheng for the reviews. I will merge it shortly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] anuengineer commented on issue #478: HDDS-2924. Fix
Pipeline#nodeIdsHash collision issue.
Posted by GitBox <gi...@apache.org>.
anuengineer commented on issue #478: HDDS-2924. Fix Pipeline#nodeIdsHash collision issue.
URL: https://github.com/apache/hadoop-ozone/pull/478#issuecomment-578360867
That is a pretty smart fix. You are absolutely right, we need no magic to find if a three node set is equal to another. +1, once @xiaoyuyao is happy.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] timmylicheng commented on issue #478: HDDS-2924. Fix
Pipeline#nodeIdsHash collision issue.
Posted by GitBox <gi...@apache.org>.
timmylicheng commented on issue #478: HDDS-2924. Fix Pipeline#nodeIdsHash collision issue.
URL: https://github.com/apache/hadoop-ozone/pull/478#issuecomment-578268557
> The checkstyle issue should be fixed in next commit. However, there is an issue when interop multi-raft with rackawareness, which is detected by the topology acceptance test. It is not related to this change but I will look into it.
I have a JIRA https://issues.apache.org/jira/browse/HDDS-2923 to fix rack awareness issue,. We may track there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] xiaoyuyao commented on issue #478: HDDS-2924. Fix
Pipeline#nodeIdsHash collision issue.
Posted by GitBox <gi...@apache.org>.
xiaoyuyao commented on issue #478: HDDS-2924. Fix Pipeline#nodeIdsHash collision issue.
URL: https://github.com/apache/hadoop-ozone/pull/478#issuecomment-578319050
Thanks @timmylicheng. In this one, I include some minor fixes around PipelinePlacementPolicy to cover the non-fallback case where we have enough nodes on different racks but are not chosen properly.
Agree, we should have the fall back fix in HDDS-2923.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] xiaoyuyao commented on issue #478: HDDS-2924. Fix
Pipeline#nodeIdsHash collision issue.
Posted by GitBox <gi...@apache.org>.
xiaoyuyao commented on issue #478: HDDS-2924. Fix Pipeline#nodeIdsHash collision issue.
URL: https://github.com/apache/hadoop-ozone/pull/478#issuecomment-577303225
The checkstyle issue should be fixed in next commit. However, there is an issue when interop multi-raft with rackawareness, which is detected by the topology acceptance test. It is not related to this change but I will look into it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] xiaoyuyao merged pull request #478: HDDS-2924. Fix
Pipeline#nodeIdsHash collision issue.
Posted by GitBox <gi...@apache.org>.
xiaoyuyao merged pull request #478: HDDS-2924. Fix Pipeline#nodeIdsHash collision issue.
URL: https://github.com/apache/hadoop-ozone/pull/478
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org