[jira] [Resolved] (MYFACES-3242) Unify logging in different project stages

["Thomas Andraschko (Jira)" <de...@myfaces.apache.org>]

     [ https://issues.apache.org/jira/browse/MYFACES-3242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thomas Andraschko resolved MYFACES-3242.
----------------------------------------
      Assignee: Thomas Andraschko
    Resolution: Fixed

tried to unifty - might still not be perfect but seems better to me now

> Unify logging in different project stages
> -----------------------------------------
>
>                 Key: MYFACES-3242
>                 URL: https://issues.apache.org/jira/browse/MYFACES-3242
>             Project: MyFaces Core
>          Issue Type: Sub-task
>          Components: General
>            Reporter: Martin Kočí
>            Assignee: Thomas Andraschko
>            Priority: Minor
>             Fix For: 2.3-next-M3
>
>
> Examples from myfaces:
> if(projectStage.equals(ProjectStage.Development) || projectStage.equals(ProjectStage.UnitTest))
>  log.warning("ALT attribute is missing for : " + uiComponent.getId());
> if (log.isLoggable(Level.WARNING)) log.warning("Graphic with id " + uiComponent.getClientId(facesContext) + " has no value (url or name).");
> Level level = Level.FINE;
> if (!_facesContext.isProjectStage(ProjectStage.Production)) {
>                         level = Level.WARNING;
> }
> if (log.isLoggable(level))
> { ...}
> if (facesContext.isProjectStage(ProjectStage.Development))
>  {
> Clarify:
> * facesContext.isProjectStage(ProjectStage.Development) vs !_facesContext.isProjectStage(ProjectStage.Production) - how to understand UnitTest and SystemTest stages when logging
> * which logs are conditioned with project stage
> * if log something with level FINE in production (performance)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)