You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2024/01/24 19:45:46 UTC
[kudu-CR] [rpc] introduce rpc pending connections metric
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20949
Change subject: [rpc] introduce rpc_pending_connections metric
......................................................................
[rpc] introduce rpc_pending_connections metric
One of the prior patches introduced 'rpc_listen_socket_rx_queue_size'
histogram-type metric. That one provides information on the history of
the RPC listening sockets' backlog of pending connections, but this new
'rpc_pending_connections' metric reports on the current total number of
pending RPC connections across all the RPC endpoints of a Kudu server.
The newly introduced metric is useful for assessing the current status
of the listening RPC sockets. It's also useful for post-mortem analysis
using the diagnostic logs that store snapshots of this new metric tied
to the timestamps when they were captured.
Change-Id: I0bfdaf9047f43495df85edba3200286f743330a8
---
M src/kudu/rpc/acceptor_pool.cc
M src/kudu/rpc/acceptor_pool.h
M src/kudu/rpc/messenger.cc
M src/kudu/rpc/messenger.h
M src/kudu/rpc/rpc-test.cc
5 files changed, 94 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/49/20949/1
--
To view, visit http://gerrit.cloudera.org:8080/20949
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0bfdaf9047f43495df85edba3200286f743330a8
Gerrit-Change-Number: 20949
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] [rpc] introduce rpc pending connections metric
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/20949 )
Change subject: [rpc] introduce rpc_pending_connections metric
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/20949
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0bfdaf9047f43495df85edba3200286f743330a8
Gerrit-Change-Number: 20949
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Wed, 24 Jan 2024 22:31:20 +0000
Gerrit-HasComments: No
[kudu-CR] [rpc] introduce rpc pending connections metric
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [rpc] introduce rpc_pending_connections metric
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/20949
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I0bfdaf9047f43495df85edba3200286f743330a8
Gerrit-Change-Number: 20949
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
[kudu-CR] [rpc] introduce rpc pending connections metric
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20949 )
Change subject: [rpc] introduce rpc_pending_connections metric
......................................................................
[rpc] introduce rpc_pending_connections metric
One of the prior patches introduced 'rpc_listen_socket_rx_queue_size'
histogram-type metric. That one provides information on the history of
the RPC listening sockets' backlog of pending connections, but this new
'rpc_pending_connections' metric reports on the current total number of
pending RPC connections across all the RPC endpoints of a Kudu server.
The newly introduced metric is useful for assessing the current status
of the listening RPC sockets. It's also useful for post-mortem analysis
using the diagnostic logs that store snapshots of this new metric tied
to the timestamps when they were captured.
Change-Id: I0bfdaf9047f43495df85edba3200286f743330a8
Reviewed-on: http://gerrit.cloudera.org:8080/20949
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
---
M src/kudu/rpc/acceptor_pool.cc
M src/kudu/rpc/acceptor_pool.h
M src/kudu/rpc/messenger.cc
M src/kudu/rpc/messenger.h
M src/kudu/rpc/rpc-test.cc
5 files changed, 94 insertions(+), 5 deletions(-)
Approvals:
Alexey Serbin: Verified
Abhishek Chennaka: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/20949
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0bfdaf9047f43495df85edba3200286f743330a8
Gerrit-Change-Number: 20949
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
[kudu-CR] [rpc] introduce rpc pending connections metric
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20949 )
Change subject: [rpc] introduce rpc_pending_connections metric
......................................................................
Patch Set 2: Verified+1
unrelated test failure in Java test (TSAN)
--
To view, visit http://gerrit.cloudera.org:8080/20949
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0bfdaf9047f43495df85edba3200286f743330a8
Gerrit-Change-Number: 20949
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Thu, 25 Jan 2024 05:44:28 +0000
Gerrit-HasComments: No
[kudu-CR] [rpc] introduce rpc pending connections metric
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/20949 )
Change subject: [rpc] introduce rpc_pending_connections metric
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/20949
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0bfdaf9047f43495df85edba3200286f743330a8
Gerrit-Change-Number: 20949
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Thu, 25 Jan 2024 18:56:13 +0000
Gerrit-HasComments: No