You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/05/01 10:30:20 UTC
[GitHub] [rocketmq-mqtt] YxAc opened a new pull request, #90: [ISSUE #22] codeCov for mqtt.cs.session
YxAc opened a new pull request, #90:
URL: https://github.com/apache/rocketmq-mqtt/pull/90
continuously submit for #22
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-mqtt] codecov-commenter commented on pull request #90: [ISSUE #22] codeCov for mqtt.cs.session
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #90:
URL: https://github.com/apache/rocketmq-mqtt/pull/90#issuecomment-1114197566
# [Codecov](https://codecov.io/gh/apache/rocketmq-mqtt/pull/90?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#90](https://codecov.io/gh/apache/rocketmq-mqtt/pull/90?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8ab5d78) into [main](https://codecov.io/gh/apache/rocketmq-mqtt/commit/4f3f12787aa0abbc42d92e0afbea5ed61839c5c0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4f3f127) will **increase** coverage by `2.28%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## main #90 +/- ##
==========================================
+ Coverage 33.38% 35.66% +2.28%
==========================================
Files 98 98
Lines 4233 4231 -2
Branches 670 669 -1
==========================================
+ Hits 1413 1509 +96
+ Misses 2562 2451 -111
- Partials 258 271 +13
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq-mqtt/pull/90?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...a/org/apache/rocketmq/mqtt/cs/session/Session.java](https://codecov.io/gh/apache/rocketmq-mqtt/pull/90/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bXF0dC1jcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbXF0dC9jcy9zZXNzaW9uL1Nlc3Npb24uamF2YQ==) | `52.89% <100.00%> (+13.04%)` | :arrow_up: |
| [...he/rocketmq/mqtt/cs/session/match/MatchAction.java](https://codecov.io/gh/apache/rocketmq-mqtt/pull/90/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bXF0dC1jcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbXF0dC9jcy9zZXNzaW9uL21hdGNoL01hdGNoQWN0aW9uLmphdmE=) | `72.61% <0.00%> (+22.61%)` | :arrow_up: |
| [...che/rocketmq/mqtt/cs/session/infly/PushAction.java](https://codecov.io/gh/apache/rocketmq-mqtt/pull/90/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bXF0dC1jcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbXF0dC9jcy9zZXNzaW9uL2luZmx5L1B1c2hBY3Rpb24uamF2YQ==) | `57.89% <0.00%> (+27.36%)` | :arrow_up: |
| [...rg/apache/rocketmq/mqtt/cs/session/QueueFresh.java](https://codecov.io/gh/apache/rocketmq-mqtt/pull/90/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bXF0dC1jcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbXF0dC9jcy9zZXNzaW9uL1F1ZXVlRnJlc2guamF2YQ==) | `90.00% <0.00%> (+90.00%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-mqtt/pull/90?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-mqtt/pull/90?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4f3f127...8ab5d78](https://codecov.io/gh/apache/rocketmq-mqtt/pull/90?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-mqtt] YxAc commented on a diff in pull request #90: [ISSUE #22] codeCov for mqtt.cs.session
Posted by GitBox <gi...@apache.org>.
YxAc commented on code in PR #90:
URL: https://github.com/apache/rocketmq-mqtt/pull/90#discussion_r865842258
##########
mqtt-cs/src/main/java/org/apache/rocketmq/mqtt/cs/session/Session.java:
##########
@@ -142,9 +142,7 @@ public Map<Subscription, Map<Queue, QueueOffset>> offsetMapSnapshot() {
}
Map<Queue, QueueOffset> queueMap = new HashMap<>(8);
Review Comment:
> the size 8 can be replaced by offsetMap.get(queueName).size()
good catch👍, done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-mqtt] tianliuliu commented on a diff in pull request #90: [ISSUE #22] codeCov for mqtt.cs.session
Posted by GitBox <gi...@apache.org>.
tianliuliu commented on code in PR #90:
URL: https://github.com/apache/rocketmq-mqtt/pull/90#discussion_r865527788
##########
mqtt-cs/src/main/java/org/apache/rocketmq/mqtt/cs/session/Session.java:
##########
@@ -142,9 +142,7 @@ public Map<Subscription, Map<Queue, QueueOffset>> offsetMapSnapshot() {
}
Map<Queue, QueueOffset> queueMap = new HashMap<>(8);
Review Comment:
the size 8 can be replaced by offsetMap.get(queueName).size()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-mqtt] tianliuliu merged pull request #90: [ISSUE #22] codeCov for mqtt.cs.session
Posted by GitBox <gi...@apache.org>.
tianliuliu merged PR #90:
URL: https://github.com/apache/rocketmq-mqtt/pull/90
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org