You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2012/12/11 00:24:09 UTC
Re: Review Request: Added registration timeout for executors
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8077/#review14270
-----------------------------------------------------------
src/slave/slave.cpp
<https://reviews.apache.org/r/8077/#comment30406>
As discussed offline, you still want to keep the gc'ing right?
- Benjamin Hindman
On Nov. 20, 2012, 3:37 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8077/
> -----------------------------------------------------------
>
> (Updated Nov. 20, 2012, 3:37 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Description
> -------
>
> This paves the way for a slave to shutdown executors that are not responsive during launch (e.g. HDFS hang during fetching executor).
>
> This fix is not enough for cgroups isolation module (enough for the process based isolation module) because it currently blocks while launching an executor.
>
>
> This addresses bug MESOS-310.
> https://issues.apache.org/jira/browse/MESOS-310
>
>
> Diffs
> -----
>
> src/master/hierarchical_allocator_process.hpp 5bcbeb99c823c3dbca0f89e19473b943c7469dab
> src/master/master.cpp 87fad0ed1eaecd59f2814d3e776b746b754b79b7
> src/slave/cgroups_isolation_module.hpp 9f80fc5a969b959b34eaea4cac40700662d7f8b2
> src/slave/constants.hpp ddf02570caf3793106b3c48e158a5bb48c1ae80c
> src/slave/constants.cpp 1735a6b55a93e6537a5a119e5345961f3d84a000
> src/slave/process_based_isolation_module.hpp efe59ebc0e8120926ea9f36b9eaa2f0b25830faf
> src/slave/process_based_isolation_module.cpp 16fd584e78db2c517d828f2576ab8a38c5ce57ad
> src/slave/reaper.cpp c0ee4b4c07fd792bcb39455b666808b712eb32c2
> src/slave/slave.hpp bbba4404e9e2b1ff1e246f017cdad704438973ba
> src/slave/slave.cpp 7deb4574943aae4cfc5da5d6b3f600042686975f
> src/tests/master_tests.cpp 948ab5dff34eeba1f3ce593a864ddf282c8b19ed
>
> Diff: https://reviews.apache.org/r/8077/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>