Name Finder Documentation

[Peter Harrington <pe...@gmail.com>]

Hi I am really glad I found OpenNLP.

I have been going through the Name Finder API documentation, and I
found two small typos in the code examples:
1. the for loop
for (String document[][] : documents) {

  for (String[] sentence : document) {
    Span nameSpans[] = find(sentence);
    // do something with the names
  }

  nameFinder.clearAdaptiveData()
}

I the find should be a method of the nameFinder object, so the line:
Span nameSpans[] = find(sentence);
should be:
Span nameSpans[] = nameFinder.find(sentence);

2. In the next code block, the sentence variable is incorrectly typed.
 It reads:
String sentence = new String[]{
    "Pierre",
    "Vinken",
    "is",
    "61",
    "years"
    "old",
    "."
    };
However I believe that should be type sentence[].

Minor typos in the documentation, let me know if there is anything I
can do to fix the documentation.

Re: Name Finder Documentation

[Jörn Kottmann <ko...@gmail.com>]

On 8/16/11 3:45 AM, Peter Harrington wrote:
> I have created a Jira ticket, and attached a patch.  Should I be on the
> opennlp-dev mailing list?
> Please excuse my n00bishness, this is the first Apache project I have helped
> out.

Over at this list we mostly discuss the development of OpenNLP itself,
you are invited to join it. It is not so much traffic anyway.

Jörn

Re: Name Finder Documentation

[Peter Harrington <pe...@gmail.com>]

I have created a Jira ticket, and attached a patch.  Should I be on the
opennlp-dev mailing list?
Please excuse my n00bishness, this is the first Apache project I have helped
out.

On Wed, Aug 10, 2011 at 1:16 AM, Jörn Kottmann <ko...@gmail.com> wrote:

> On 8/10/11 2:42 AM, Peter Harrington wrote:
>
>> Minor typos in the documentation, let me know if there is anything I
>> can do to fix the documentation.
>>
>
> Thanks for pointing us to these mistakes.
>
> It would be really nice if you could create a patch to fix them,
> to do this, you would open a jira and then attach the patch to it.
>
> BR,
> Jörn
>
>

Re: Name Finder Documentation

[Jörn Kottmann <ko...@gmail.com>]

On 8/10/11 2:42 AM, Peter Harrington wrote:
> Minor typos in the documentation, let me know if there is anything I
> can do to fix the documentation.

Thanks for pointing us to these mistakes.

It would be really nice if you could create a patch to fix them,
to do this, you would open a jira and then attach the patch to it.

BR,
Jörn