You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by shukitchan <gi...@git.apache.org> on 2016/06/01 06:32:05 UTC
[GitHub] trafficserver pull request: TS-4497: fix fetch api to release async item soo...
GitHub user shukitchan opened a pull request:
https://github.com/apache/trafficserver/pull/685
TS-4497: fix fetch api to release async item sooner
@sudheerv this is what we have been discussing for a while. With TS-3777, the ts.fetch() of ts_lua is no longer working fine. I finally figure out that the original plugin code committed is not performing cleanup correctly.
Thanks. please take a look.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shukitchan/trafficserver swrsie
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/685.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #685
----
commit 76446b6289208ba666a2641164a0473d3d7dc80a
Author: Kit Chan <ki...@apache.org>
Date: 2016-06-01T06:22:14Z
fix fetch api to release async item sooner
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #685: TS-4497: fix fetch api to release async item soone...
Posted by sudheerv <gi...@git.apache.org>.
Github user sudheerv commented on the issue:
https://github.com/apache/trafficserver/pull/685
@shukitchan : is the "deleted" state protecting against multiple threads calling the cleanup? If so, it may still not be enough, without a mutex of some sort?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #685: TS-4497: fix fetch api to release async ite...
Posted by shukitchan <gi...@git.apache.org>.
Github user shukitchan closed the pull request at:
https://github.com/apache/trafficserver/pull/685
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #685: TS-4497: fix fetch api to release async item soone...
Posted by sudheerv <gi...@git.apache.org>.
Github user sudheerv commented on the issue:
https://github.com/apache/trafficserver/pull/685
\U0001f44d
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #685: TS-4497: fix fetch api to release async item soone...
Posted by shukitchan <gi...@git.apache.org>.
Github user shukitchan commented on the issue:
https://github.com/apache/trafficserver/pull/685
@sudheerv I made the change already. Please take a look.
will definitely squash into a single commit before merge. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #685: TS-4497: fix fetch api to release async item soone...
Posted by shukitchan <gi...@git.apache.org>.
Github user shukitchan commented on the issue:
https://github.com/apache/trafficserver/pull/685
The added call to ts_lua_fetch_multi_cleanup() is protected with a mutex.
However, i think this function is called in another place and i need to protect that as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---