You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/09/08 15:22:30 UTC

[GitHub] [ignite-3] kgusakov commented on a change in pull request #321: IGNITE-15288 Fully implement RaftGroupService

kgusakov commented on a change in pull request #321:
URL: https://github.com/apache/ignite-3/pull/321#discussion_r704527540



##########
File path: modules/raft/src/main/java/org/apache/ignite/raft/jraft/entity/PeerId.java
##########
@@ -287,6 +287,9 @@ else if (!this.endpoint.equals(other.endpoint)) {
     }
 
     public static PeerId fromPeer(Peer p) {

Review comment:
       Use case here https://github.com/apache/ignite-3/pull/321/files#diff-bfb2b9f4058e3034104dbd6a860a201f04ac4066c2b2411bd1f717e23c26ab4aR128 - I thought it will be useful to support transparent null pointer processing here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org