[jira] [Commented] (HBASE-4542) add filter info to slow query logging

["Phabricator (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-4542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13197413#comment-13197413 ] 

Phabricator commented on HBASE-4542:
------------------------------------

mbautin has commented on the revision "[jira] [HBASE-4542] Add filter info to slow query logging".

  @zhiqiu: don't worry about filling those fields in the "Submit Patch" form. We can correct those fields later if necessary. The purpose of setting JIRA status to "Patch Available" is to make the Apache Jenkins continuous integration server pick up the patch and run a subset of the test suite ("small" and "Medium" tests) against it.

  In some cases, the format of the patch automatically generated by Phabricator and uploaded to JIRA is such that it cannot be applied by the standard patch command for some reason. In those cases, Hadoop QA (Jenkins server) will post an update to the JIRA saying that it could not apply the patch. If that happens, you can generate a patch manually using the following command:

    git format-patch --no-prefix HEAD^..HEAD

  Then, upload this patch to the JIRA (https://issues.apache.org/jira/browse/HBASE-4542) using the "+" button at the top of the "Attachments" section of the page.


REVISION DETAIL
  https://reviews.facebook.net/D1539

                
> add filter info to slow query logging
> -------------------------------------
>
>                 Key: HBASE-4542
>                 URL: https://issues.apache.org/jira/browse/HBASE-4542
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Kannan Muthukkaruppan
>            Assignee: Madhuwanti Vaidya
>         Attachments: D1263.2.patch, D1539.1.patch
>
>
> Slow query log doesn't report filters in effect.
> For example:
> {code}
> (operationTooSlow): \
> {"processingtimems":3468,"client":"10.138.43.206:40035","timeRange": [0,9223372036854775807],\
> "starttimems":1317772005821,"responsesize":42411, \
> "class":"HRegionServer","table":"myTable","families":{"CF1":"ALL"]},\
> "row":"6c3b8efa132f0219b7621ed1e5c8c70b","queuetimems":0,\
> "method":"get","totalColumns":1,"maxVersions":1,"storeLimit":-1}
> {code}
> the above would suggest that all columns of myTable:CF1 are being requested for the given row. But in reality there could be filters in effect (such as ColumnPrefixFilter, ColumnRangeFilter, TimestampsFilter() etc.). We should enhance the slow query log to capture & report this information.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira