Re: [PR] fix(sql-lab): use function valueGetter for GridTable row numbers [superset]

["rusackas (via GitHub)" <gi...@apache.org>]

rusackas commented on PR #41574:
URL: https://github.com/apache/superset/pull/41574#issuecomment-5013097486

   Thanks for this, small fix but a legit one. ag-grid's string-expression valueGetters indeed run through an eval-based parser, so swapping to a plain function is great when running with a strict script-src. The two failing jest shards look like the unrelated SavedQueryList flake, not this change, so I'll get this in once that clears.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org