You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bigtop.apache.org by youngwookim <gi...@git.apache.org> on 2017/02/27 08:18:18 UTC
[GitHub] bigtop pull request #181: BIGTOP-2689: Upgrade Zeppelin to version 0.7
GitHub user youngwookim opened a pull request:
https://github.com/apache/bigtop/pull/181
BIGTOP-2689: Upgrade Zeppelin to version 0.7
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/youngwookim/bigtop BIGTOP-2689
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/bigtop/pull/181.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #181
----
commit da0d9faf61cc9154cfd456a69f14c6a2fe5f0430
Author: Youngwoo Kim <yw...@apache.org>
Date: 2017-02-07T03:10:28Z
BIGTOP-2689: Upgrade Zeppelin to version 0.7
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bigtop pull request #181: BIGTOP-2689: Upgrade Zeppelin to version 0.7
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/181#discussion_r103611570
--- Diff: bigtop-packages/src/common/zeppelin/install_zeppelin.sh ---
@@ -115,19 +115,14 @@ install -d -m 0755 $PREFIX/var/log/zeppelin/
install -d -m 0755 $PREFIX/var/run/zeppelin/
install -d -m 0755 $PREFIX/var/run/zeppelin/webapps
-tar --wildcards --strip-components=1 -C $PREFIX/$LIB_DIR -zxf ${BUILD_DIR}/zeppelin-distribution/target/zeppelin-*.tar.gz \*/bin/\*
-tar --wildcards --strip-components=1 -C $PREFIX/$LIB_DIR -zxf ${BUILD_DIR}/zeppelin-distribution/target/zeppelin-*.tar.gz \*/interpreter/\*
-tar --wildcards --strip-components=1 -C $PREFIX/$LIB_DIR -zxf ${BUILD_DIR}/zeppelin-distribution/target/zeppelin-*.tar.gz \*/lib/\*
-tar --wildcards --strip-components=1 -C $PREFIX/$LIB_DIR -zxf ${BUILD_DIR}/zeppelin-distribution/target/zeppelin-*.tar.gz \*zeppelin-server\*.jar
-tar --wildcards --strip-components=1 -C $PREFIX/$LIB_DIR -zxf ${BUILD_DIR}/zeppelin-distribution/target/zeppelin-*.tar.gz \*zeppelin-web\*.war
-tar --wildcards --strip-components=1 -C $PREFIX/var/lib/zeppelin -zxf ${BUILD_DIR}/zeppelin-distribution/target/zeppelin-*.tar.gz \*/notebook/\*
+cp -a ${BUILD_DIR}/build/dist/{bin,interpreter,lib,zeppelin-web-0.7.0.war} $PREFIX/$LIB_DIR/
--- End diff --
use * instead of hardcoding `0.7.0`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bigtop pull request #181: BIGTOP-2689: Upgrade Zeppelin to version 0.7
Posted by ejono <gi...@git.apache.org>.
Github user ejono commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/181#discussion_r103763248
--- Diff: bigtop-packages/src/common/zeppelin/install_zeppelin.sh ---
@@ -115,19 +115,14 @@ install -d -m 0755 $PREFIX/var/log/zeppelin/
install -d -m 0755 $PREFIX/var/run/zeppelin/
install -d -m 0755 $PREFIX/var/run/zeppelin/webapps
-tar --wildcards --strip-components=1 -C $PREFIX/$LIB_DIR -zxf ${BUILD_DIR}/zeppelin-distribution/target/zeppelin-*.tar.gz \*/bin/\*
-tar --wildcards --strip-components=1 -C $PREFIX/$LIB_DIR -zxf ${BUILD_DIR}/zeppelin-distribution/target/zeppelin-*.tar.gz \*/interpreter/\*
-tar --wildcards --strip-components=1 -C $PREFIX/$LIB_DIR -zxf ${BUILD_DIR}/zeppelin-distribution/target/zeppelin-*.tar.gz \*/lib/\*
-tar --wildcards --strip-components=1 -C $PREFIX/$LIB_DIR -zxf ${BUILD_DIR}/zeppelin-distribution/target/zeppelin-*.tar.gz \*zeppelin-server\*.jar
-tar --wildcards --strip-components=1 -C $PREFIX/$LIB_DIR -zxf ${BUILD_DIR}/zeppelin-distribution/target/zeppelin-*.tar.gz \*zeppelin-web\*.war
-tar --wildcards --strip-components=1 -C $PREFIX/var/lib/zeppelin -zxf ${BUILD_DIR}/zeppelin-distribution/target/zeppelin-*.tar.gz \*/notebook/\*
+cp -a ${BUILD_DIR}/build/dist/{bin,interpreter,lib,zeppelin-web-0.7.0.war} $PREFIX/$LIB_DIR/
--- End diff --
Ah, I missed that. Good catch, @felixcheung. +1 on using ${ZEPPELIN_VERSION}.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bigtop pull request #181: BIGTOP-2689: Upgrade Zeppelin to version 0.7
Posted by evans-ye <gi...@git.apache.org>.
Github user evans-ye commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/181#discussion_r103716786
--- Diff: bigtop-packages/src/common/zeppelin/install_zeppelin.sh ---
@@ -115,19 +115,14 @@ install -d -m 0755 $PREFIX/var/log/zeppelin/
install -d -m 0755 $PREFIX/var/run/zeppelin/
install -d -m 0755 $PREFIX/var/run/zeppelin/webapps
-tar --wildcards --strip-components=1 -C $PREFIX/$LIB_DIR -zxf ${BUILD_DIR}/zeppelin-distribution/target/zeppelin-*.tar.gz \*/bin/\*
-tar --wildcards --strip-components=1 -C $PREFIX/$LIB_DIR -zxf ${BUILD_DIR}/zeppelin-distribution/target/zeppelin-*.tar.gz \*/interpreter/\*
-tar --wildcards --strip-components=1 -C $PREFIX/$LIB_DIR -zxf ${BUILD_DIR}/zeppelin-distribution/target/zeppelin-*.tar.gz \*/lib/\*
-tar --wildcards --strip-components=1 -C $PREFIX/$LIB_DIR -zxf ${BUILD_DIR}/zeppelin-distribution/target/zeppelin-*.tar.gz \*zeppelin-server\*.jar
-tar --wildcards --strip-components=1 -C $PREFIX/$LIB_DIR -zxf ${BUILD_DIR}/zeppelin-distribution/target/zeppelin-*.tar.gz \*zeppelin-web\*.war
-tar --wildcards --strip-components=1 -C $PREFIX/var/lib/zeppelin -zxf ${BUILD_DIR}/zeppelin-distribution/target/zeppelin-*.tar.gz \*/notebook/\*
+cp -a ${BUILD_DIR}/build/dist/{bin,interpreter,lib,zeppelin-web-0.7.0.war} $PREFIX/$LIB_DIR/
--- End diff --
Sounds like a good suggestion. Or we can replace it by ZEPPELIN_VERSION?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---