You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2020/01/27 18:54:32 UTC
[Impala-ASF-CR] Remove dead code: FifoMultimap
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15109
Change subject: Remove dead code: FifoMultimap
......................................................................
Remove dead code: FifoMultimap
The FifoMultimap (be/src/util/lru-cache.h, etc) was used in an older
version of the file handle cache. It is now unused, so this removes
it.
Testing:
- Ran a clean compile
Change-Id: I2f5008e2cb05d093f7dc03f889f9846a95b1e9a7
---
M be/src/util/CMakeLists.txt
D be/src/util/lru-cache-test.cc
D be/src/util/lru-cache.h
D be/src/util/lru-cache.inline.h
4 files changed, 0 insertions(+), 385 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/09/15109/1
--
To view, visit http://gerrit.cloudera.org:8080/15109
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2f5008e2cb05d093f7dc03f889f9846a95b1e9a7
Gerrit-Change-Number: 15109
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
[Impala-ASF-CR] Remove dead code: FifoMultimap
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15109 )
Change subject: Remove dead code: FifoMultimap
......................................................................
Remove dead code: FifoMultimap
The FifoMultimap (be/src/util/lru-cache.h, etc) was used in an older
version of the file handle cache. It is now unused, so this removes
it.
Testing:
- Ran a clean compile
Change-Id: I2f5008e2cb05d093f7dc03f889f9846a95b1e9a7
Reviewed-on: http://gerrit.cloudera.org:8080/15109
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/util/CMakeLists.txt
D be/src/util/lru-cache-test.cc
D be/src/util/lru-cache.h
D be/src/util/lru-cache.inline.h
4 files changed, 0 insertions(+), 385 deletions(-)
Approvals:
Tim Armstrong: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/15109
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2f5008e2cb05d093f7dc03f889f9846a95b1e9a7
Gerrit-Change-Number: 15109
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] Remove dead code: FifoMultimap
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15109 )
Change subject: Remove dead code: FifoMultimap
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5470/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/15109
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f5008e2cb05d093f7dc03f889f9846a95b1e9a7
Gerrit-Change-Number: 15109
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 27 Jan 2020 19:48:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Remove dead code: FifoMultimap
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15109 )
Change subject: Remove dead code: FifoMultimap
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5532/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/15109
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f5008e2cb05d093f7dc03f889f9846a95b1e9a7
Gerrit-Change-Number: 15109
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 27 Jan 2020 19:39:23 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Remove dead code: FifoMultimap
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15109 )
Change subject: Remove dead code: FifoMultimap
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15109
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f5008e2cb05d093f7dc03f889f9846a95b1e9a7
Gerrit-Change-Number: 15109
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 27 Jan 2020 19:45:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Remove dead code: FifoMultimap
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15109 )
Change subject: Remove dead code: FifoMultimap
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/15109
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f5008e2cb05d093f7dc03f889f9846a95b1e9a7
Gerrit-Change-Number: 15109
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Jan 2020 00:37:00 +0000
Gerrit-HasComments: No