You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@continuum.apache.org by Brett Porter <br...@apache.org> on 2010/06/15 08:49:59 UTC
Re: svn commit: r954720 - /continuum/trunk/continuum-core/src/main/java/org/apache/maven/continuum/notification/mail/MailContinuumNotifier.java
That's:
http://jira.codehaus.org/browse/CONTINUUM-2520
I think it'd be good for others to go through the issues in the Unscheduled bucket from time to time, to make sure the issues are valid (and check for patches!) I try to do it once a week...
- Brett
On 15/06/2010, at 4:18 PM, ctan@apache.org wrote:
> Author: ctan
> Date: Tue Jun 15 06:18:51 2010
> New Revision: 954720
>
> URL: http://svn.apache.org/viewvc?rev=954720&view=rev
> Log:
> prevent NPE when build result or project is null
>
> Modified:
> continuum/trunk/continuum-core/src/main/java/org/apache/maven/continuum/notification/mail/MailContinuumNotifier.java
>
> Modified: continuum/trunk/continuum-core/src/main/java/org/apache/maven/continuum/notification/mail/MailContinuumNotifier.java
> URL: http://svn.apache.org/viewvc/continuum/trunk/continuum-core/src/main/java/org/apache/maven/continuum/notification/mail/MailContinuumNotifier.java?rev=954720&r1=954719&r2=954720&view=diff
> ==============================================================================
> --- continuum/trunk/continuum-core/src/main/java/org/apache/maven/continuum/notification/mail/MailContinuumNotifier.java (original)
> +++ continuum/trunk/continuum-core/src/main/java/org/apache/maven/continuum/notification/mail/MailContinuumNotifier.java Tue Jun 15 06:18:51 2010
> @@ -251,8 +251,17 @@ public class MailContinuumNotifier
> Project project = context.getProject();
> List<ProjectNotifier> notifiers = context.getNotifiers();
> BuildResult build = context.getBuildResult();
> - log.error( "br state="+build.getState() );
> - log.error( "project state="+project.getState() );
> +
> + if ( build != null )
> + {
> + log.error( "br state="+build.getState() );
> + }
> +
> + if ( project != null )
> + {
> + log.error( "project state="+project.getState() );
> + }
> +
> BuildDefinition buildDefinition = context.getBuildDefinition();
> ProjectScmRoot projectScmRoot = context.getProjectScmRoot();
>
>
>
--
Brett Porter
brett@apache.org
http://brettporter.wordpress.com/
Re: svn commit: r954720 - /continuum/trunk/continuum-core/src/main/java/org/apache/maven/continuum/notification/mail/MailContinuumNotifier.java
Posted by Marica Tan <ma...@gmail.com>.
Ok noted Brett :) Thanks!
--
Marica
On Tue, Jun 15, 2010 at 2:49 PM, Brett Porter <br...@apache.org> wrote:
> That's:
> http://jira.codehaus.org/browse/CONTINUUM-2520
>
> I think it'd be good for others to go through the issues in the Unscheduled
> bucket from time to time, to make sure the issues are valid (and check for
> patches!) I try to do it once a week...
>
> - Brett
>
> On 15/06/2010, at 4:18 PM, ctan@apache.org wrote:
>
> > Author: ctan
> > Date: Tue Jun 15 06:18:51 2010
> > New Revision: 954720
> >
> > URL: http://svn.apache.org/viewvc?rev=954720&view=rev
> > Log:
> > prevent NPE when build result or project is null
> >
> > Modified:
> >
> continuum/trunk/continuum-core/src/main/java/org/apache/maven/continuum/notification/mail/MailContinuumNotifier.java
> >
> > Modified:
> continuum/trunk/continuum-core/src/main/java/org/apache/maven/continuum/notification/mail/MailContinuumNotifier.java
> > URL:
> http://svn.apache.org/viewvc/continuum/trunk/continuum-core/src/main/java/org/apache/maven/continuum/notification/mail/MailContinuumNotifier.java?rev=954720&r1=954719&r2=954720&view=diff
> >
> ==============================================================================
> > ---
> continuum/trunk/continuum-core/src/main/java/org/apache/maven/continuum/notification/mail/MailContinuumNotifier.java
> (original)
> > +++
> continuum/trunk/continuum-core/src/main/java/org/apache/maven/continuum/notification/mail/MailContinuumNotifier.java
> Tue Jun 15 06:18:51 2010
> > @@ -251,8 +251,17 @@ public class MailContinuumNotifier
> > Project project = context.getProject();
> > List<ProjectNotifier> notifiers = context.getNotifiers();
> > BuildResult build = context.getBuildResult();
> > - log.error( "br state="+build.getState() );
> > - log.error( "project state="+project.getState() );
> > +
> > + if ( build != null )
> > + {
> > + log.error( "br state="+build.getState() );
> > + }
> > +
> > + if ( project != null )
> > + {
> > + log.error( "project state="+project.getState() );
> > + }
> > +
> > BuildDefinition buildDefinition = context.getBuildDefinition();
> > ProjectScmRoot projectScmRoot = context.getProjectScmRoot();
> >
> >
> >
>
> --
> Brett Porter
> brett@apache.org
> http://brettporter.wordpress.com/
>
>
>
>
>