You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2018/01/20 00:35:52 UTC
[kudu-CR] tablet: squelch unused variable warning
Hello Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/9087
to review the following change.
Change subject: tablet: squelch unused variable warning
......................................................................
tablet: squelch unused variable warning
../../src/kudu/tablet/tablet.cc: In member function ‘std::shared_ptr<kudu::tablet::RowSet> kudu::tablet::Tablet::FindBestDMSToFlush(const ReplaySizeMap&) const’:
../../src/kudu/tablet/tablet.cc:1893:11: warning: variable ‘retention_size’ set but not used [-Wunused-but-set-variable]
int64_t retention_size = 0;
^
Change-Id: I8302eb0902e005d1d193eea1bac87c83dfb27d22
---
M src/kudu/tablet/tablet.cc
1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/87/9087/1
--
To view, visit http://gerrit.cloudera.org:8080/9087
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8302eb0902e005d1d193eea1bac87c83dfb27d22
Gerrit-Change-Number: 9087
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] tablet: squelch unused variable warning
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9087 )
Change subject: tablet: squelch unused variable warning
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9087
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8302eb0902e005d1d193eea1bac87c83dfb27d22
Gerrit-Change-Number: 9087
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Mon, 22 Jan 2018 23:23:54 +0000
Gerrit-HasComments: No
[kudu-CR] tablet: squelch unused variable warning
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9087 )
Change subject: tablet: squelch unused variable warning
......................................................................
Patch Set 1: Verified+1
One alter_table-randomized-test timed out, certainly not related.
--
To view, visit http://gerrit.cloudera.org:8080/9087
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8302eb0902e005d1d193eea1bac87c83dfb27d22
Gerrit-Change-Number: 9087
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Sun, 21 Jan 2018 20:12:47 +0000
Gerrit-HasComments: No
[kudu-CR] tablet: squelch unused variable warning
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/9087 )
Change subject: tablet: squelch unused variable warning
......................................................................
Removed reviewer Kudu Jenkins with the following votes:
* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/9087
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I8302eb0902e005d1d193eea1bac87c83dfb27d22
Gerrit-Change-Number: 9087
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] tablet: squelch unused variable warning
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9087 )
Change subject: tablet: squelch unused variable warning
......................................................................
tablet: squelch unused variable warning
../../src/kudu/tablet/tablet.cc: In member function ‘std::shared_ptr<kudu::tablet::RowSet> kudu::tablet::Tablet::FindBestDMSToFlush(const ReplaySizeMap&) const’:
../../src/kudu/tablet/tablet.cc:1893:11: warning: variable ‘retention_size’ set but not used [-Wunused-but-set-variable]
int64_t retention_size = 0;
^
Change-Id: I8302eb0902e005d1d193eea1bac87c83dfb27d22
Reviewed-on: http://gerrit.cloudera.org:8080/9087
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M src/kudu/tablet/tablet.cc
1 file changed, 0 insertions(+), 2 deletions(-)
Approvals:
Kudu Jenkins: Verified
Todd Lipcon: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/9087
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8302eb0902e005d1d193eea1bac87c83dfb27d22
Gerrit-Change-Number: 9087
Gerrit-PatchSet: 3
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>