You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2013/03/02 23:08:42 UTC
Re: Review Request: Added a Bytes abstraction.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9120/
-----------------------------------------------------------
(Updated March 2, 2013, 10:08 p.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
Rebased off trunk.
Description
-------
See MESOS-273.
I'm also using Bytes in: https://reviews.apache.org/r/9121/
I also made some whitespace changes in duration.hpp, mostly to generate discussion around vertical alignment when appropriate.
This addresses bug MESOS-273.
https://issues.apache.org/jira/browse/MESOS-273
Diffs (updated)
-----
third_party/libprocess/third_party/stout/Makefile.am 15e09d3e9e5e722cc88393132f40448485cd48ab
third_party/libprocess/third_party/stout/include/stout/bytes.hpp PRE-CREATION
third_party/libprocess/third_party/stout/include/stout/duration.hpp 17d2d316fcd994212f41577f54c112e41e061bc6
third_party/libprocess/third_party/stout/tests/tests.cpp ae95c65d5a231c26d5730477058f58872b56e24a
Diff: https://reviews.apache.org/r/9120/diff/
Testing
-------
Added tests, make check.
Thanks,
Ben Mahler
Re: Review Request: Added a Bytes abstraction.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9120/#review17400
-----------------------------------------------------------
Ship it!
third_party/libprocess/third_party/stout/include/stout/bytes.hpp
<https://reviews.apache.org/r/9120/#comment36926>
Error.
third_party/libprocess/third_party/stout/include/stout/bytes.hpp
<https://reviews.apache.org/r/9120/#comment36927>
Error.
- Benjamin Hindman
On March 2, 2013, 10:08 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9120/
> -----------------------------------------------------------
>
> (Updated March 2, 2013, 10:08 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> See MESOS-273.
>
> I'm also using Bytes in: https://reviews.apache.org/r/9121/
>
> I also made some whitespace changes in duration.hpp, mostly to generate discussion around vertical alignment when appropriate.
>
>
> This addresses bug MESOS-273.
> https://issues.apache.org/jira/browse/MESOS-273
>
>
> Diffs
> -----
>
> third_party/libprocess/third_party/stout/Makefile.am 15e09d3e9e5e722cc88393132f40448485cd48ab
> third_party/libprocess/third_party/stout/include/stout/bytes.hpp PRE-CREATION
> third_party/libprocess/third_party/stout/include/stout/duration.hpp 17d2d316fcd994212f41577f54c112e41e061bc6
> third_party/libprocess/third_party/stout/tests/tests.cpp ae95c65d5a231c26d5730477058f58872b56e24a
>
> Diff: https://reviews.apache.org/r/9120/diff/
>
>
> Testing
> -------
>
> Added tests, make check.
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Added a Bytes abstraction.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9120/
-----------------------------------------------------------
(Updated March 5, 2013, 7:24 p.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
Updated to trunk + benh review.
Description
-------
See MESOS-273.
I'm also using Bytes in: https://reviews.apache.org/r/9121/
I also made some whitespace changes in duration.hpp, mostly to generate discussion around vertical alignment when appropriate.
This addresses bug MESOS-273.
https://issues.apache.org/jira/browse/MESOS-273
Diffs (updated)
-----
third_party/libprocess/third_party/stout/Makefile.am 15e09d3e9e5e722cc88393132f40448485cd48ab
third_party/libprocess/third_party/stout/include/stout/bytes.hpp PRE-CREATION
third_party/libprocess/third_party/stout/include/stout/duration.hpp 17d2d316fcd994212f41577f54c112e41e061bc6
third_party/libprocess/third_party/stout/tests/tests.cpp ae95c65d5a231c26d5730477058f58872b56e24a
Diff: https://reviews.apache.org/r/9120/diff/
Testing
-------
Added tests, make check.
Thanks,
Ben Mahler