Re: cvs commit: httpd-proxy/module-2.0 mod_proxy.c mod_proxy.h mod_proxy.mak proxy_connect.c proxy_ftp.c proxy_http.c

[Justin Erenkrantz <je...@ebuilt.com>]

On Tue, May 22, 2001 at 07:37:29PM -0000, orlikowski@apache.org wrote:
>   @@ -155,7 +155,7 @@
>         */
>    
>        /* we break the URL into host, port, uri */
>   -    if (HTTP_OK != ap_parse_hostinfo_components(p, url, &uri)) {
>   +    if (HTTP_OK != apr_uri_parse_hostinfo_components(p, url, &uri)) {
>    	return ap_proxyerror(r, HTTP_BAD_REQUEST,
>    			     apr_pstrcat(p, "URI cannot be parsed: ", url, NULL));
>        }

This will break because HTTP_OK isn't what is returned from
apr_uri_parse_hostinfo_components anymore.  It just returns APR_SUCCESS
or APR_EGENERAL.  You have a few other places that check for HTTP_OK.
I expect the proxy is in a bad state now.  =)

I wasn't going to add APR_URI_ERROR to apr_errno.h.  I'm with Cliff
and others on adding overly descriptive errors.  It either works
(APR_SUCCESS), or it didn't (APR_EGENERAL).  -- justin