[hbase] branch branch-2 updated: HBASE-25653 Add units and round off region size to 2 digits after decimal (#3046)

[nd...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

ndimiduk pushed a commit to branch branch-2
in repository https://gitbox.apache.org/repos/asf/hbase.git


The following commit(s) were added to refs/heads/branch-2 by this push:
     new 35520a7  HBASE-25653 Add units and round off region size to 2 digits after decimal (#3046)
35520a7 is described below

commit 35520a72fb3dbf68e5818632679497aebe56e798
Author: DivyeshChandra <di...@gmail.com>
AuthorDate: Wed Mar 17 10:02:12 2021 +0530

    HBASE-25653 Add units and round off region size to 2 digits after decimal (#3046)
    
    Signed-off-by: stack <st...@duboce.net>
    Reviewed-by: Viraj Jasani <vj...@apache.org>
---
 .../master/normalizer/SimpleRegionNormalizer.java   | 21 ++++++++++++---------
 1 file changed, 12 insertions(+), 9 deletions(-)

diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/SimpleRegionNormalizer.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/SimpleRegionNormalizer.java
index 006f8e7..b6d74ec 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/SimpleRegionNormalizer.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/SimpleRegionNormalizer.java
@@ -282,8 +282,8 @@ class SimpleRegionNormalizer implements RegionNormalizer, ConfigurationObserver
       if (tableDescriptor != null) {
         targetRegionCount = tableDescriptor.getNormalizerTargetRegionCount();
         targetRegionSize = tableDescriptor.getNormalizerTargetRegionSize();
-        LOG.debug("Table {} configured with target region count {}, target region size {}", table,
-          targetRegionCount, targetRegionSize);
+        LOG.debug("Table {} configured with target region count {}, target region size {} MB",
+          table, targetRegionCount, targetRegionSize);
       }
     } catch (IOException e) {
       LOG.warn("TableDescriptor for {} unavailable, table-level target region count and size"
@@ -301,8 +301,8 @@ class SimpleRegionNormalizer implements RegionNormalizer, ConfigurationObserver
       } else {
         avgRegionSize = totalSizeMb / (double) regionCount;
       }
-      LOG.debug("Table {}, total aggregated regions size: {} and average region size {}", table,
-        totalSizeMb, avgRegionSize);
+      LOG.debug("Table {}, total aggregated regions size: {} MB and average region size {} MB",
+        table, totalSizeMb, String.format("%.3f", avgRegionSize));
     }
 
     return avgRegionSize;
@@ -353,8 +353,9 @@ class SimpleRegionNormalizer implements RegionNormalizer, ConfigurationObserver
     if (avgRegionSizeMb < configuration.getMergeMinRegionSizeMb()) {
       return Collections.emptyList();
     }
-    LOG.debug("Computing normalization plan for table {}. average region size: {}, number of"
-      + " regions: {}.", ctx.getTableName(), avgRegionSizeMb, ctx.getTableRegions().size());
+    LOG.debug("Computing normalization plan for table {}. average region size: {} MB, number of"
+      + " regions: {}.", ctx.getTableName(), avgRegionSizeMb,
+      ctx.getTableRegions().size());
 
     // this nested loop walks the table's region chain once, looking for contiguous sequences of
     // regions that meet the criteria for merge. The outer loop tracks the starting point of the
@@ -424,7 +425,8 @@ class SimpleRegionNormalizer implements RegionNormalizer, ConfigurationObserver
    */
   private List<NormalizationPlan> computeSplitNormalizationPlans(final NormalizeContext ctx) {
     final double avgRegionSize = ctx.getAverageRegionSizeMb();
-    LOG.debug("Table {}, average region size: {}", ctx.getTableName(), avgRegionSize);
+    LOG.debug("Table {}, average region size: {} MB", ctx.getTableName(),
+      String.format("%.3f", avgRegionSize));
 
     final List<NormalizationPlan> plans = new ArrayList<>();
     for (final RegionInfo hri : ctx.getTableRegions()) {
@@ -433,8 +435,9 @@ class SimpleRegionNormalizer implements RegionNormalizer, ConfigurationObserver
       }
       final long regionSizeMb = getRegionSizeMB(hri);
       if (regionSizeMb > 2 * avgRegionSize) {
-        LOG.info("Table {}, large region {} has size {}, more than twice avg size {}, splitting",
-          ctx.getTableName(), hri.getRegionNameAsString(), regionSizeMb, avgRegionSize);
+        LOG.info("Table {}, large region {} has size {} MB, more than twice avg size {} MB, "
+            + "splitting", ctx.getTableName(), hri.getRegionNameAsString(), regionSizeMb,
+          String.format("%.3f", avgRegionSize));
         plans.add(new SplitNormalizationPlan(hri, regionSizeMb));
       }
     }