You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@impala.apache.org by "Lars Volker (Code Review)" <ge...@cloudera.org> on 2018/06/01 18:10:26 UTC

[native-toolchain-CR] Bump libunwind version to 1.3-rc1

Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10576


Change subject: Bump libunwind version to 1.3-rc1
......................................................................

Bump libunwind version to 1.3-rc1

This changes bumps libunwind to version 1.3-rc1, the same version as in
Kudu. It also adds two patches to improve its interaction with asan and
tsan. The patch we had for 1.1 is not needed anymore.

It also adds a third patch to make the build and tests pass on CentOS 5.

I tested this on my local dev environment with a prototype that rebases
our KRPC dependencies. I also tested this with a full build on a private
Jenkins job.

Change-Id: Ieb277ba55fb28145367d90dcbd868bf6b3c1710a
---
M buildall.sh
M source/libunwind/build.sh
D source/libunwind/libunwind-1.1-patches/0001-Build-libunwind-1.1-on-ppc64le.patch
A source/libunwind/libunwind-1.3-rc1-patches/0001-libunwind-Use-syscall-directly-in-write_validate-to-avoid-ASAN.patch
A source/libunwind/libunwind-1.3-rc1-patches/0002-libunwind-trace-cache-destructor.patch
A source/libunwind/libunwind-1.3-rc1-patches/0003-Fix-Build-On-Centos-5-Without-pipe2.patch
6 files changed, 145 insertions(+), 11 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/76/10576/1
-- 
To view, visit http://gerrit.cloudera.org:8080/10576
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieb277ba55fb28145367d90dcbd868bf6b3c1710a
Gerrit-Change-Number: 10576
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>

[native-toolchain-CR] Bump libunwind version to 1.3-rc1

Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.

Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10576 )

Change subject: Bump libunwind version to 1.3-rc1
......................................................................


Patch Set 3: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/10576
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb277ba55fb28145367d90dcbd868bf6b3c1710a
Gerrit-Change-Number: 10576
Gerrit-PatchSet: 3
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com>
Gerrit-Comment-Date: Fri, 01 Jun 2018 18:21:04 +0000
Gerrit-HasComments: No

[native-toolchain-CR] Bump libunwind version to 1.3-rc1

Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.

Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10576 )

Change subject: Bump libunwind version to 1.3-rc1
......................................................................


Patch Set 3: Code-Review+1

(1 comment)

Thanks for the review. I addressed your comment in PS3.

Carrying Zoram's +1.

http://gerrit.cloudera.org:8080/#/c/10576/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/10576/2//COMMIT_MSG@14
PS2, Line 14: The patch disables a test for remote unwinding. I wasn't able to figure
> Typo: unwindind -> unwinding?
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/10576
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb277ba55fb28145367d90dcbd868bf6b3c1710a
Gerrit-Change-Number: 10576
Gerrit-PatchSet: 3
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com>
Gerrit-Comment-Date: Fri, 01 Jun 2018 18:16:52 +0000
Gerrit-HasComments: Yes

[native-toolchain-CR] Bump libunwind version to 1.3-rc1

Posted by "Michael Ho (Code Review)" <ge...@cloudera.org>.

Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10576 )

Change subject: Bump libunwind version to 1.3-rc1
......................................................................


Patch Set 4: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/10576
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb277ba55fb28145367d90dcbd868bf6b3c1710a
Gerrit-Change-Number: 10576
Gerrit-PatchSet: 4
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com>
Gerrit-Comment-Date: Fri, 01 Jun 2018 20:30:18 +0000
Gerrit-HasComments: No

[native-toolchain-CR] Bump libunwind version to 1.3-rc1

Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.

Lars Volker has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10576 )

Change subject: Bump libunwind version to 1.3-rc1
......................................................................

Bump libunwind version to 1.3-rc1

This changes bumps libunwind to version 1.3-rc1, the same version as in
Kudu. It also adds two patches to improve its interaction with asan and
tsan. The patch we had for 1.1 is not needed anymore.

It also adds a third patch to make the build and tests pass on CentOS 5.
The patch disables a test for remote unwinding. I wasn't able to figure
out why the test failed, but we currently only plan to use local
unwinding.

I tested this on my local dev environment with a prototype that rebases
our KRPC dependencies. I also tested this with a full build on a private
Jenkins job.

Change-Id: Ieb277ba55fb28145367d90dcbd868bf6b3c1710a
Reviewed-on: http://gerrit.cloudera.org:8080/10576
Reviewed-by: Lars Volker <lv...@cloudera.com>
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Lars Volker <lv...@cloudera.com>
---
M buildall.sh
M source/libunwind/build.sh
D source/libunwind/libunwind-1.1-patches/0001-Build-libunwind-1.1-on-ppc64le.patch
A source/libunwind/libunwind-1.3-rc1-patches/0001-libunwind-Use-syscall-directly-in-write_validate-to-avoid-ASAN.patch
A source/libunwind/libunwind-1.3-rc1-patches/0002-libunwind-trace-cache-destructor.patch
A source/libunwind/libunwind-1.3-rc1-patches/0003-Fix-Build-On-Centos-5-Without-pipe2.patch
6 files changed, 145 insertions(+), 11 deletions(-)

Approvals:
  Lars Volker: Looks good to me, but someone else must approve; Verified
  Tim Armstrong: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/10576
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieb277ba55fb28145367d90dcbd868bf6b3c1710a
Gerrit-Change-Number: 10576
Gerrit-PatchSet: 4
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com>

[native-toolchain-CR] Bump libunwind version to 1.3-rc1

Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.

Hello Michael Ho, Zoram Thanga, Tim Armstrong,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/10576

to look at the new patch set (#3).

Change subject: Bump libunwind version to 1.3-rc1
......................................................................

Bump libunwind version to 1.3-rc1

This changes bumps libunwind to version 1.3-rc1, the same version as in
Kudu. It also adds two patches to improve its interaction with asan and
tsan. The patch we had for 1.1 is not needed anymore.

It also adds a third patch to make the build and tests pass on CentOS 5.
The patch disables a test for remote unwinding. I wasn't able to figure
out why the test failed, but we currently only plan to use local
unwinding.

I tested this on my local dev environment with a prototype that rebases
our KRPC dependencies. I also tested this with a full build on a private
Jenkins job.

Change-Id: Ieb277ba55fb28145367d90dcbd868bf6b3c1710a
---
M buildall.sh
M source/libunwind/build.sh
D source/libunwind/libunwind-1.1-patches/0001-Build-libunwind-1.1-on-ppc64le.patch
A source/libunwind/libunwind-1.3-rc1-patches/0001-libunwind-Use-syscall-directly-in-write_validate-to-avoid-ASAN.patch
A source/libunwind/libunwind-1.3-rc1-patches/0002-libunwind-trace-cache-destructor.patch
A source/libunwind/libunwind-1.3-rc1-patches/0003-Fix-Build-On-Centos-5-Without-pipe2.patch
6 files changed, 145 insertions(+), 11 deletions(-)

git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/76/10576/3
--
To view, visit http://gerrit.cloudera.org:8080/10576
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ieb277ba55fb28145367d90dcbd868bf6b3c1710a
Gerrit-Change-Number: 10576
Gerrit-PatchSet: 3
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com>

[native-toolchain-CR] Bump libunwind version to 1.3-rc1

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10576 )

Change subject: Bump libunwind version to 1.3-rc1
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/10576
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb277ba55fb28145367d90dcbd868bf6b3c1710a
Gerrit-Change-Number: 10576
Gerrit-PatchSet: 3
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com>
Gerrit-Comment-Date: Fri, 01 Jun 2018 18:19:46 +0000
Gerrit-HasComments: No

[native-toolchain-CR] Bump libunwind version to 1.3-rc1

Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.

Hello Michael Ho, Tim Armstrong,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/10576

to look at the new patch set (#2).

Change subject: Bump libunwind version to 1.3-rc1
......................................................................

Bump libunwind version to 1.3-rc1

This changes bumps libunwind to version 1.3-rc1, the same version as in
Kudu. It also adds two patches to improve its interaction with asan and
tsan. The patch we had for 1.1 is not needed anymore.

It also adds a third patch to make the build and tests pass on CentOS 5.
The patch disables a test for remote unwindind. I wasn't able to figure
out why the test failed, but we currently only plan to use local
unwinding.

I tested this on my local dev environment with a prototype that rebases
our KRPC dependencies. I also tested this with a full build on a private
Jenkins job.

git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/76/10576/2
--
To view, visit http://gerrit.cloudera.org:8080/10576
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ieb277ba55fb28145367d90dcbd868bf6b3c1710a
Gerrit-Change-Number: 10576
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[native-toolchain-CR] Bump libunwind version to 1.3-rc1

Posted by "Zoram Thanga (Code Review)" <ge...@cloudera.org>.

Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/10576 )

Change subject: Bump libunwind version to 1.3-rc1
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10576/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/10576/2//COMMIT_MSG@14
PS2, Line 14: The patch disables a test for remote unwindind. I wasn't able to figure
Typo: unwindind -> unwinding?



-- 
To view, visit http://gerrit.cloudera.org:8080/10576
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb277ba55fb28145367d90dcbd868bf6b3c1710a
Gerrit-Change-Number: 10576
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com>
Gerrit-Comment-Date: Fri, 01 Jun 2018 18:15:45 +0000
Gerrit-HasComments: Yes