[GitHub] [arrow] westonpace commented on a change in pull request #12339: ARROW-14908: [C++][R] Dataset hash join segfaults on Windows

[GitBox <gi...@apache.org>]

westonpace commented on a change in pull request #12339:
URL: https://github.com/apache/arrow/pull/12339#discussion_r806238789



##########
File path: cpp/src/arrow/compute/exec/hash_join.cc
##########
@@ -103,7 +103,7 @@ class HashJoinBasicImpl : public HashJoinImpl {
     filter_ = std::move(filter);
     output_batch_callback_ = std::move(output_batch_callback);
     finished_callback_ = std::move(finished_callback);
-    local_states_.resize(num_threads);
+    local_states_.resize(num_threads + 1);  // +1 for calling thread + worker thread

Review comment:
       ```suggestion
       local_states_.resize(num_threads + 1);  // +1 for calling thread + worker threads
   ```

##########
File path: cpp/src/arrow/compute/exec/hash_join_dict.cc
##########
@@ -566,7 +566,7 @@ Status HashJoinDictBuildMulti::PostDecode(
 }
 
 void HashJoinDictProbeMulti::Init(size_t num_threads) {
-  local_states_.resize(num_threads);
+  local_states_.resize(num_threads + 1);  // +1 for calling thread + worker thread

Review comment:
       ```suggestion
     local_states_.resize(num_threads + 1);  // +1 for calling thread + worker threads
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org