You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/29 16:56:13 UTC
[GitHub] [arrow] ritchie46 opened a new pull request #9363: ARROW-11430: [Rust] zip kernel: combine arrays based on boolean mask
ritchie46 opened a new pull request #9363:
URL: https://github.com/apache/arrow/pull/9363
This PR proposes a kernel that combines two arrays based on a boolean mask.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb closed pull request #9363: ARROW-11430: [Rust] zip kernel: combine arrays based on boolean mask
Posted by GitBox <gi...@apache.org>.
alamb closed pull request #9363:
URL: https://github.com/apache/arrow/pull/9363
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ritchie46 edited a comment on pull request #9363: ARROW-11430: [Rust] zip kernel: combine arrays based on boolean mask
Posted by GitBox <gi...@apache.org>.
ritchie46 edited a comment on pull request #9363:
URL: https://github.com/apache/arrow/pull/9363#issuecomment-773860896
> Hey @ritchie46 please look at the failing lint test, might need a cargo +stable fmt. Thanks
Oh, yes I am on nightly. Will do!
*edit*
Strange, no changes here when I `fmt` :thinking:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ritchie46 edited a comment on pull request #9363: ARROW-11430: [Rust] zip kernel: combine arrays based on boolean mask
Posted by GitBox <gi...@apache.org>.
ritchie46 edited a comment on pull request #9363:
URL: https://github.com/apache/arrow/pull/9363#issuecomment-773860896
> Hey @ritchie46 please look at the failing lint test, might need a cargo +stable fmt. Thanks
Oh, yes I am on nightly. Will do!
*edit*
Strange, no changes here when I `fmt` :thinking:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #9363: ARROW-11430: [Rust] zip kernel: combine arrays based on boolean mask
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #9363:
URL: https://github.com/apache/arrow/pull/9363#issuecomment-775091605
Thanks @ritchie46 -- and again thank you for all your recent help
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ritchie46 commented on pull request #9363: ARROW-11430: [Rust] zip kernel: combine arrays based on boolean mask
Posted by GitBox <gi...@apache.org>.
ritchie46 commented on pull request #9363:
URL: https://github.com/apache/arrow/pull/9363#issuecomment-774666915
> I think this one will be ready to go once the conflicts are addressed
I see I forgot the license header, I added the license and did a rebase on master. @alamb, all should be fixed now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #9363: ARROW-11430: [Rust] zip kernel: combine arrays based on boolean mask
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #9363:
URL: https://github.com/apache/arrow/pull/9363#issuecomment-774660762
I think this one will be ready to go once the conflicts are addressed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nevi-me commented on pull request #9363: ARROW-11430: [Rust] zip kernel: combine arrays based on boolean mask
Posted by GitBox <gi...@apache.org>.
nevi-me commented on pull request #9363:
URL: https://github.com/apache/arrow/pull/9363#issuecomment-773677171
Hey @ritchie46 please look at the failing lint test, might need a `cargo +stable fmt`. Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ritchie46 commented on pull request #9363: ARROW-11430: [Rust] zip kernel: combine arrays based on boolean mask
Posted by GitBox <gi...@apache.org>.
ritchie46 commented on pull request #9363:
URL: https://github.com/apache/arrow/pull/9363#issuecomment-773860896
> Hey @ritchie46 please look at the failing lint test, might need a cargo +stable fmt. Thanks
Oh, yes I am on nightly. Will do!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io edited a comment on pull request #9363: ARROW-11430: [Rust] zip kernel: combine arrays based on boolean mask
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9363:
URL: https://github.com/apache/arrow/pull/9363#issuecomment-769949763
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9363?src=pr&el=h1) Report
> Merging [#9363](https://codecov.io/gh/apache/arrow/pull/9363?src=pr&el=desc) (1312b28) into [master](https://codecov.io/gh/apache/arrow/commit/39dfd626cdcafdf37c22d81f669be41d5e408ef1?el=desc) (39dfd62) will **increase** coverage by `0.00%`.
> The diff coverage is `82.75%`.
[](https://codecov.io/gh/apache/arrow/pull/9363?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9363 +/- ##
=======================================
Coverage 82.11% 82.11%
=======================================
Files 232 233 +1
Lines 54331 54359 +28
=======================================
+ Hits 44613 44637 +24
- Misses 9718 9722 +4
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9363?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [rust/arrow/src/compute/kernels/zip.rs](https://codecov.io/gh/apache/arrow/pull/9363/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS9rZXJuZWxzL3ppcC5ycw==) | `82.14% <82.14%> (ø)` | |
| [rust/arrow/src/compute/kernels/filter.rs](https://codecov.io/gh/apache/arrow/pull/9363/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS9rZXJuZWxzL2ZpbHRlci5ycw==) | `97.71% <100.00%> (ø)` | |
| [rust/arrow/src/array/transform/fixed\_binary.rs](https://codecov.io/gh/apache/arrow/pull/9363/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvdHJhbnNmb3JtL2ZpeGVkX2JpbmFyeS5ycw==) | `84.21% <0.00%> (+5.26%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9363?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9363?src=pr&el=footer). Last update [39dfd62...1312b28](https://codecov.io/gh/apache/arrow/pull/9363?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io commented on pull request #9363: ARROW-11430: [Rust] zip kernel: combine arrays based on boolean mask
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #9363:
URL: https://github.com/apache/arrow/pull/9363#issuecomment-769949763
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9363?src=pr&el=h1) Report
> Merging [#9363](https://codecov.io/gh/apache/arrow/pull/9363?src=pr&el=desc) (94023f5) into [master](https://codecov.io/gh/apache/arrow/commit/71dab27098775228340ecb4e8a15870967d7cf91?el=desc) (71dab27) will **decrease** coverage by `0.03%`.
> The diff coverage is `82.75%`.
[](https://codecov.io/gh/apache/arrow/pull/9363?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9363 +/- ##
==========================================
- Coverage 81.98% 81.95% -0.04%
==========================================
Files 216 217 +1
Lines 53299 53375 +76
==========================================
+ Hits 43699 43741 +42
- Misses 9600 9634 +34
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9363?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [rust/arrow/src/compute/kernels/zip.rs](https://codecov.io/gh/apache/arrow/pull/9363/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS9rZXJuZWxzL3ppcC5ycw==) | `82.14% <82.14%> (ø)` | |
| [rust/arrow/src/compute/kernels/filter.rs](https://codecov.io/gh/apache/arrow/pull/9363/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS9rZXJuZWxzL2ZpbHRlci5ycw==) | `97.71% <100.00%> (ø)` | |
| [rust/datafusion/src/scalar.rs](https://codecov.io/gh/apache/arrow/pull/9363/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9zY2FsYXIucnM=) | `55.85% <0.00%> (-3.12%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9363?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9363?src=pr&el=footer). Last update [71dab27...94023f5](https://codecov.io/gh/apache/arrow/pull/9363?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nevi-me commented on pull request #9363: ARROW-11430: [Rust] zip kernel: combine arrays based on boolean mask
Posted by GitBox <gi...@apache.org>.
nevi-me commented on pull request #9363:
URL: https://github.com/apache/arrow/pull/9363#issuecomment-773677171
Hey @ritchie46 please look at the failing lint test, might need a `cargo +stable fmt`. Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9363: ARROW-11430: [Rust] zip kernel: combine arrays based on boolean mask
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9363:
URL: https://github.com/apache/arrow/pull/9363#issuecomment-769938924
https://issues.apache.org/jira/browse/ARROW-11430
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ritchie46 commented on pull request #9363: ARROW-11430: [Rust] zip kernel: combine arrays based on boolean mask
Posted by GitBox <gi...@apache.org>.
ritchie46 commented on pull request #9363:
URL: https://github.com/apache/arrow/pull/9363#issuecomment-773860896
> Hey @ritchie46 please look at the failing lint test, might need a cargo +stable fmt. Thanks
Oh, yes I am on nightly. Will do!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ritchie46 commented on pull request #9363: ARROW-11430: [Rust] zip kernel: combine arrays based on boolean mask
Posted by GitBox <gi...@apache.org>.
ritchie46 commented on pull request #9363:
URL: https://github.com/apache/arrow/pull/9363#issuecomment-775243062
Happy to help! :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org