You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "amorynan (via GitHub)" <gi...@apache.org> on 2024/03/20 08:00:04 UTC
[PR] [FIX](serde )pick 27965 for decimalv2 [doris]
amorynan opened a new pull request, #32533:
URL: https://github.com/apache/doris/pull/32533
## Proposed changes
fix datetimev2 serde parse from string with scale
pick: https://github.com/apache/doris/pull/27965
Issue Number: close #xxx
<!--Describe your changes.-->
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](serde )pick 27965 for decimalv2 [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32533:
URL: https://github.com/apache/doris/pull/32533#issuecomment-2011186707
TeamCity be ut coverage result:
Function Coverage: 37.82% (8043/21269)
Line Coverage: 29.47% (65634/222678)
Region Coverage: 28.95% (33786/116700)
Branch Coverage: 24.79% (17338/69946)
Coverage Report: http://coverage.selectdb-in.cc/coverage/c941ab4b4d3299dd2c04f7596077dddc3b218c01_c941ab4b4d3299dd2c04f7596077dddc3b218c01/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](serde )pick 27965 for decimalv2 [doris]
Posted by "amorynan (via GitHub)" <gi...@apache.org>.
amorynan commented on PR #32533:
URL: https://github.com/apache/doris/pull/32533#issuecomment-2008982328
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](serde )pick 27965 for decimalv2 [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32533:
URL: https://github.com/apache/doris/pull/32533#issuecomment-2011169374
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](serde )pick 27965 for decimalv2 [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on code in PR #32533:
URL: https://github.com/apache/doris/pull/32533#discussion_r1533200081
##########
be/src/vec/data_types/serde/data_type_datetimev2_serde.cpp:
##########
@@ -79,8 +79,8 @@ Status DataTypeDateTimeV2SerDe::deserialize_one_cell_from_json(IColumn& column,
}
} else if (ReadBuffer rb(slice.data, slice.size);
- !read_datetime_v2_text_impl<UInt64>(val, rb)) {
- return Status::InvalidDataFormat("parse date fail, string: '{}'",
+ !read_datetime_v2_text_impl<UInt64>(val, rb, scale)) {
+ return Status::InvalidArgument("parse date fail, string: '{}'",
std::string(rb.position(), rb.count()).c_str());
Review Comment:
why not pick related regression tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](serde )pick 27965 for decimalv2 [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32533:
URL: https://github.com/apache/doris/pull/32533#issuecomment-2008982218
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](serde )pick 27965 for decimalv2 [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #32533:
URL: https://github.com/apache/doris/pull/32533
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](serde )pick 27965 for decimalv2 [doris]
Posted by "amorynan (via GitHub)" <gi...@apache.org>.
amorynan commented on code in PR #32533:
URL: https://github.com/apache/doris/pull/32533#discussion_r1533205233
##########
be/src/vec/data_types/serde/data_type_datetimev2_serde.cpp:
##########
@@ -79,8 +79,8 @@ Status DataTypeDateTimeV2SerDe::deserialize_one_cell_from_json(IColumn& column,
}
} else if (ReadBuffer rb(slice.data, slice.size);
- !read_datetime_v2_text_impl<UInt64>(val, rb)) {
- return Status::InvalidDataFormat("parse date fail, string: '{}'",
+ !read_datetime_v2_text_impl<UInt64>(val, rb, scale)) {
+ return Status::InvalidArgument("parse date fail, string: '{}'",
std::string(rb.position(), rb.count()).c_str());
Review Comment:
the out file is generate from master which round behavior is not compatible for 2.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](serde )pick 27965 for decimalv2 [doris]
Posted by "amorynan (via GitHub)" <gi...@apache.org>.
amorynan commented on PR #32533:
URL: https://github.com/apache/doris/pull/32533#issuecomment-2010937363
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](serde )pick 27965 for decimalv2 [doris]
Posted by "amorynan (via GitHub)" <gi...@apache.org>.
amorynan commented on PR #32533:
URL: https://github.com/apache/doris/pull/32533#issuecomment-2011164364
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](serde )pick 27965 for decimalv2 [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #32533:
URL: https://github.com/apache/doris/pull/32533#issuecomment-2009040461
TeamCity be ut coverage result:
Function Coverage: 37.81% (8041/21268)
Line Coverage: 29.47% (65620/222675)
Region Coverage: 28.95% (33779/116687)
Branch Coverage: 24.79% (17336/69944)
Coverage Report: http://coverage.selectdb-in.cc/coverage/b9f8377bb68d15bda8f4a750ce1d4234d59bd389_b9f8377bb68d15bda8f4a750ce1d4234d59bd389/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [FIX](serde )pick 27965 for decimalv2 [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32533:
URL: https://github.com/apache/doris/pull/32533#issuecomment-2008990815
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org