You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by pa...@apache.org on 2023/05/27 03:37:31 UTC

[shardingsphere] branch master updated: Fix sonar issue in SchemaMetaDataLoaderEngine (#25912)

This is an automated email from the ASF dual-hosted git repository.

panjuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new bcb0bd88eac Fix sonar issue in SchemaMetaDataLoaderEngine (#25912)
bcb0bd88eac is described below

commit bcb0bd88eac66a9fd854703e0972daf083a58448
Author: Zhengqiang Duan <du...@apache.org>
AuthorDate: Sat May 27 11:37:19 2023 +0800

    Fix sonar issue in SchemaMetaDataLoaderEngine (#25912)
---
 .../database/schema/loader/metadata/SchemaMetaDataLoaderEngine.java  | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/infra/common/src/main/java/org/apache/shardingsphere/infra/metadata/database/schema/loader/metadata/SchemaMetaDataLoaderEngine.java b/infra/common/src/main/java/org/apache/shardingsphere/infra/metadata/database/schema/loader/metadata/SchemaMetaDataLoaderEngine.java
index fae78cf8293..644e499778b 100644
--- a/infra/common/src/main/java/org/apache/shardingsphere/infra/metadata/database/schema/loader/metadata/SchemaMetaDataLoaderEngine.java
+++ b/infra/common/src/main/java/org/apache/shardingsphere/infra/metadata/database/schema/loader/metadata/SchemaMetaDataLoaderEngine.java
@@ -81,10 +81,7 @@ public final class SchemaMetaDataLoaderEngine {
         if (dialectSchemaMetaDataLoader.isPresent()) {
             try {
                 return dialectSchemaMetaDataLoader.get().load(material.getDataSource(), material.getActualTableNames(), material.getDefaultSchemaName());
-                // TODO replace Exception to SQLException when all dialect loader can handle meta data load normally
-                // CHECKSTYLE:OFF
-            } catch (final Exception ex) {
-                // CHECKSTYLE:ON
+            } catch (final SQLException ex) {
                 log.debug("Dialect load schema meta data error.", ex);
             }
         }