[GitHub] [airflow] kanetkarster commented on a change in pull request #5812: [AIRFLOW-4449] updated default permission for custom roles to 'Viewer'

[GitBox <gi...@apache.org>]

kanetkarster commented on a change in pull request #5812: [AIRFLOW-4449] updated default permission for custom roles to 'Viewer'
URL: https://github.com/apache/airflow/pull/5812#discussion_r361181554
 
 

 ##########
 File path: airflow/www/security.py
 ##########
 @@ -27,7 +27,7 @@
 from airflow.exceptions import AirflowException
 from airflow.utils.db import provide_session
 from airflow.utils.log.logging_mixin import LoggingMixin
-from airflow.www.app import appbuilder
+from airflow.www.app import app, appbuilder
 
 Review comment:
   I had initially used appbuilder, like was done in `get_user_roles` but that caused all of the tests to fail, so I started directly using `app.config`. Is there something I might have been missing?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services