You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@celix.apache.org by GitBox <gi...@apache.org> on 2022/12/01 12:37:19 UTC
[GitHub] [celix] PengZheng opened a new pull request, #449: Feature/uclibc support
PengZheng opened a new pull request, #449:
URL: https://github.com/apache/celix/pull/449
Fix all problems found when compiling against uclibc:
- Lack of `backtrace`. The most plausible way of supporting it is via [libunwind](https://github.com/libunwind/libunwind)
- Lack of `pthread_setname_np`. Indeed, we can use `prctl(PR_SET_NAME)` to set the task name of the calling thread. To set task name of arbitrary `pthread_t`, we have to know the corresponding tid for a given pthread_t. Unfortunately there is no `pthread_getthreadid_np` in uclibc.
Though uclibc is still used in newest SOCs in my day job, it's not actively maintained any more. And there is no rush to support these features on platforms using uclibc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [celix] PengZheng commented on pull request #449: Feature/uclibc support
Posted by GitBox <gi...@apache.org>.
PengZheng commented on PR #449:
URL: https://github.com/apache/celix/pull/449#issuecomment-1334710661
> Is it an idea/possible to also add a GitHub action to build celix using uclibc (i.e. using buildroot) and maybe even run some tests in a uclibc busybox image?
Note maybe this is for a separate PR, but for now the risk is that we unintentionally introduce issues for uclibc if it is not tested in a CI pipeline.
It's a very good idea! We have already been hurt by this kind of bugs, e.g. #404 and #426.
Conan could be very handy for cross tool-chains management and cross-compiling, and Qemu might be helpful for local debugging.
How about we open an issue to have a good discussion of the work flow, especially of the local one.
After finishing #441, I will be happy to help adding such support to our CI if it has not happened then.
> And it there any benefits looking to musl libc and/or dietlibc?
Supporting multiple libc will help improve Celix's portability. I think musl libc is a good choice. As for dietlibc, I have no knowledge of it. If supporting tiny Linux is one of Celix's aims, then supporting dietlibc will be no harm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [celix] PengZheng commented on a diff in pull request #449: Feature/uclibc support
Posted by GitBox <gi...@apache.org>.
PengZheng commented on code in PR #449:
URL: https://github.com/apache/celix/pull/449#discussion_r1037727702
##########
libs/utils/src/celix_log_utils.c:
##########
@@ -95,6 +97,7 @@ celix_log_level_e celix_logUtils_logLevelFromStringWithCheck(const char *str, ce
}
static inline void celix_logUtils_inlinePrintBacktrace(FILE *stream) {
+#ifndef __UCLIBC__
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [celix] PengZheng merged pull request #449: Feature/uclibc support
Posted by GitBox <gi...@apache.org>.
PengZheng merged PR #449:
URL: https://github.com/apache/celix/pull/449
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [celix] codecov-commenter commented on pull request #449: Feature/uclibc support
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #449:
URL: https://github.com/apache/celix/pull/449#issuecomment-1333720104
# [Codecov](https://codecov.io/gh/apache/celix/pull/449?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#449](https://codecov.io/gh/apache/celix/pull/449?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d2c8350) into [master](https://codecov.io/gh/apache/celix/commit/5969a2c3fa39a3fc90c73ca0e8c1517d73ddd139?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5969a2c) will **decrease** coverage by `0.37%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #449 +/- ##
==========================================
- Coverage 75.03% 74.66% -0.38%
==========================================
Files 199 199
Lines 29616 29616
==========================================
- Hits 22223 22113 -110
- Misses 7393 7503 +110
```
| [Impacted Files](https://codecov.io/gh/apache/celix/pull/449?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [libs/utils/src/celix\_log\_utils.c](https://codecov.io/gh/apache/celix/pull/449/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlicy91dGlscy9zcmMvY2VsaXhfbG9nX3V0aWxzLmM=) | `85.71% <ø> (ø)` | |
| [libs/utils/src/celix\_threads.c](https://codecov.io/gh/apache/celix/pull/449/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlicy91dGlscy9zcmMvY2VsaXhfdGhyZWFkcy5j) | `75.24% <ø> (ø)` | |
| [...ubsub\_admin\_udp\_mc/src/pubsub\_udpmc\_topic\_sender.c](https://codecov.io/gh/apache/celix/pull/449/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3VkcF9tYy9zcmMvcHVic3ViX3VkcG1jX3RvcGljX3NlbmRlci5j) | `55.74% <0.00%> (-28.74%)` | :arrow_down: |
| [bundles/pubsub/pubsub\_admin\_udp\_mc/src/large\_udp.c](https://codecov.io/gh/apache/celix/pull/449/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3VkcF9tYy9zcmMvbGFyZ2VfdWRwLmM=) | `10.61% <0.00%> (-22.91%)` | :arrow_down: |
| [...ubsub\_serializer\_json/src/pubsub\_serializer\_impl.c](https://codecov.io/gh/apache/celix/pull/449/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX3NlcmlhbGl6ZXJfanNvbi9zcmMvcHVic3ViX3NlcmlhbGl6ZXJfaW1wbC5j) | `54.54% <0.00%> (-8.37%)` | :arrow_down: |
| [libs/utils/src/hash\_map.c](https://codecov.io/gh/apache/celix/pull/449/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlicy91dGlscy9zcmMvaGFzaF9tYXAuYw==) | `94.38% <0.00%> (+1.12%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [celix] pnoltes commented on a diff in pull request #449: Feature/uclibc support
Posted by GitBox <gi...@apache.org>.
pnoltes commented on code in PR #449:
URL: https://github.com/apache/celix/pull/449#discussion_r1037417476
##########
libs/utils/src/celix_log_utils.c:
##########
@@ -95,6 +97,7 @@ celix_log_level_e celix_logUtils_logLevelFromStringWithCheck(const char *str, ce
}
static inline void celix_logUtils_inlinePrintBacktrace(FILE *stream) {
+#ifndef __UCLIBC__
Review Comment:
Maybe it is better to place the while function in a ifdef, else, endif so that the function argument can be marked as unused for the uclibc case.
e.g.
```
#ifndef __UCLIBC__
static inline void celix_logUtils_inlinePrintBacktrace(FILE *stream) {
...
}
#else
static inline void celix_logUtils_inlinePrintBacktrace(FILE *stream __attribute__((unused))) {
//nop
}
#endif
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [celix] pnoltes commented on pull request #449: Feature/uclibc support
Posted by GitBox <gi...@apache.org>.
pnoltes commented on PR #449:
URL: https://github.com/apache/celix/pull/449#issuecomment-1334155593
Nice to see support for uclibc.
Is it an idea/possible to also add a GitHub action to build celix using uclibc (i.e. using buildroot) and maybe even run some tests in a uclibc busybox image?
Note maybe this is for a separate PR, but for now the risk is that we unintentionally introduce issues for uclibc if it is not tested in a CI pipeline.
And it there any benefits looking to musl libc and/or dietlibc?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org