[GitHub] [spark] cloud-fan edited a comment on issue #24149: [SPARK-27207][SQL] : Ensure aggregate buffers are initialized again for So…

[GitBox <gi...@apache.org>]

cloud-fan edited a comment on issue #24149: [SPARK-27207][SQL] : Ensure aggregate buffers are initialized again for So…
URL: https://github.com/apache/spark/pull/24149#issuecomment-490165060
 
 
   After some more thoughts, I have some different ideas now.
   
   I checked the `TypedImperativeAggregate` implementations, the `initialize` method is used to initialize the aggregate buffer, not to initialize the `TypedImperativeAggregate` instance. That said, `TypedImperativeAggregate` implementations should be stateless.
   
   Come back to this bug, it can only be exposed if the UDAF needs to initialize itself, which should not be allowed. I think we can just add some doc to `TypedImperativeAggregate`, saying that it must be stateless. Sorry for the back and forth!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org