You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2014/03/26 14:14:15 UTC
Review Request 19679: Unittests for Service resource an all it's attributes
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19679/
-----------------------------------------------------------
Review request for Ambari and Vitalyi Brodetskyi.
Bugs: AMBARI-5220
https://issues.apache.org/jira/browse/AMBARI-5220
Repository: ambari
Description
-------
Test Service resource management resource. Test all actions and all the
attributes. Note here we should not call directly provider methods like
action_create, but make resource management library do that for us, by calling
env.run(). In other case test won't cover resources definitions, and other
import logic
Diffs
-----
ambari-agent/src/test/python/resource_management/TestServiceResource.py PRE-CREATION
Diff: https://reviews.apache.org/r/19679/diff/
Testing
-------
Thanks,
Andrew Onischuk
Re: Review Request 19679: Unittests for Service resource an all it's
attributes
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19679/#review38599
-----------------------------------------------------------
Ship it!
Ship It!
- Vitalyi Brodetskyi
On March 26, 2014, 1:14 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19679/
> -----------------------------------------------------------
>
> (Updated March 26, 2014, 1:14 p.m.)
>
>
> Review request for Ambari and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-5220
> https://issues.apache.org/jira/browse/AMBARI-5220
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Test Service resource management resource. Test all actions and all the
> attributes. Note here we should not call directly provider methods like
> action_create, but make resource management library do that for us, by calling
> env.run(). In other case test won't cover resources definitions, and other
> import logic
>
>
> Diffs
> -----
>
> ambari-agent/src/test/python/resource_management/TestServiceResource.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/19679/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Onischuk
>
>