You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by corneadoug <gi...@git.apache.org> on 2015/11/27 06:09:08 UTC
[GitHub] incubator-zeppelin pull request: ZEPPELIN-462 - Fix Navbar CSS
GitHub user corneadoug opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/483
ZEPPELIN-462 - Fix Navbar CSS
This PR is fixing https://issues.apache.org/jira/browse/ZEPPELIN-462
Navbar alignment has been reworked
![screen shot 2015-11-27 at 2 07 12 pm](https://cloud.githubusercontent.com/assets/710411/11434457/39d0cfb2-9510-11e5-9bf6-c59f91c10ddd.png)
And Navbar style on smaller resolutions has been fixed
![screen shot 2015-11-27 at 1 33 35 pm](https://cloud.githubusercontent.com/assets/710411/11434460/4469b286-9510-11e5-8b66-25e037343e95.png)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/corneadoug/incubator-zeppelin fix/docCss
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/483.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #483
----
commit cdd76cd377d9ef4eb9a52fa3bd18e333e8784380
Author: Damien CORNEAU <co...@gmail.com>
Date: 2015-11-27T04:49:49Z
Fix Navbar style
commit c648748fe84ff86dbaecd514d3a1203aac3f2666
Author: Damien CORNEAU <co...@gmail.com>
Date: 2015-11-27T05:04:27Z
Fix CSS formating
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-462 - Fix Navbar CSS
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/483#issuecomment-160276838
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-462 - Fix Navbar CSS
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/483#issuecomment-160129427
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-462 - Fix Navbar CSS
Posted by r-kamath <gi...@git.apache.org>.
Github user r-kamath commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/483#issuecomment-160080960
tested. LGTM :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-462 - Fix Navbar CSS
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/483
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-462 - Fix Navbar CSS
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/483#issuecomment-160250426
Merge if there is no more discussions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---