You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@carbondata.apache.org by GitBox <gi...@apache.org> on 2019/01/27 12:04:22 UTC

[GitHub] xuchuanyin commented on issue #3084: [CARBONDATA-3258] Add more test case for mv datamap

xuchuanyin commented on issue #3084: [CARBONDATA-3258] Add more test case for mv datamap
URL: https://github.com/apache/carbondata/pull/3084#issuecomment-457912099
 
 
   @qiuchenjian please consider to remove the meaningless empty lines to make the code compact and easier to read.
   
   Besides I think the tests is not well organized. The name 'ExceptionTest', 'FunctionTest' is too broad and it seems these two files will contain all the tests for MV which is definitely not. So I'd recommend to break these tests to the place where it belongs OR use meaningful name to group the testcases. Please not add unrelated testcases in one file.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services