[GitHub] [spark] EnricoMi commented on a diff in pull request #36150: [SPARK-38864][SQL] Add melt / unpivot to Dataset

[GitBox <gi...@apache.org>]

EnricoMi commented on code in PR #36150:
URL: https://github.com/apache/spark/pull/36150#discussion_r919026261


##########
core/src/main/resources/error/error-classes.json:
##########
@@ -256,6 +256,18 @@
       "Key <keyValue> does not exist. Use `try_element_at` to tolerate non-existent key and return NULL instead. If necessary set <config> to \"false\" to bypass this error."
     ]
   },
+  "MELT_REQUIRES_VALUE_COLUMNS" : {

Review Comment:
   You are saying use `UNIVOT` instead of `MELT` in this line only? Or use `unpivot` wherever this PR mentions `melt`? API, catalyst, docu?
   
   In the latter case: should we at least have `Dataset.melt` as an alias for `Dataset.unpivot`, given in Pandas and PySpark Pandas the method *is called*  `melt`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org