You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by ab...@apache.org on 2023/02/15 10:37:57 UTC
[druid] branch master updated: Flip boolean logic so the test description makes sense (#13805)
This is an automated email from the ASF dual-hosted git repository.
abhishek pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/druid.git
The following commit(s) were added to refs/heads/master by this push:
new e5ecb4d6aa Flip boolean logic so the test description makes sense (#13805)
e5ecb4d6aa is described below
commit e5ecb4d6aa6b6bc77c8d21e117c8e266079ad74e
Author: Elliott Freis <10...@users.noreply.github.com>
AuthorDate: Wed Feb 15 02:37:49 2023 -0800
Flip boolean logic so the test description makes sense (#13805)
Co-authored-by: Elliott Freis <el...@Elliott-Freis.local>
---
.github/workflows/reusable-unit-tests.yml | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/.github/workflows/reusable-unit-tests.yml b/.github/workflows/reusable-unit-tests.yml
index 7e48fc633b..03563a47a1 100644
--- a/.github/workflows/reusable-unit-tests.yml
+++ b/.github/workflows/reusable-unit-tests.yml
@@ -75,8 +75,13 @@ jobs:
run: |
export base_ref=${{ github.base_ref }}
echo "GITHUB_BASE_REF=${base_ref}" >> $GITHUB_ENV
- export druid_use_default_value_for_null=${{ inputs.sql_compatibility }}
- echo "DRUID_USE_DEFAULT_VALUE_FOR_NULL=${druid_use_default_value_for_null}" >> $GITHUB_ENV
+ # If sql_compatibilty is true, we want to set default_value_for_null
+ # which enables compatibility mode
+ if (${{ inputs.sql_compatibility }} == true); then
+ echo "DRUID_USE_DEFAULT_VALUE_FOR_NULL=false" >> $GITHUB_ENV
+ else
+ echo "DRUID_USE_DEFAULT_VALUE_FOR_NULL=true" >> $GITHUB_ENV
+ fi
- name: fetch base branch for test coverage
if: ${{ github.base_ref != '' }}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org