[GitHub] [hbase] bbeaudreault commented on a diff in pull request #4914: HBASE-27491: do not clear cache on RejectedExecutionException

[GitBox <gi...@apache.org>]

bbeaudreault commented on code in PR #4914:
URL: https://github.com/apache/hbase/pull/4914#discussion_r1040083976


##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRequestFutureImpl.java:
##########
@@ -715,17 +715,24 @@ private void receiveGlobalFailure(MultiAction rsActions, ServerName server, int
     errorsByServer.reportServerError(server);
     Retry canRetry = errorsByServer.canTryMore(numAttempt) ? Retry.YES : Retry.NO_RETRIES_EXHAUSTED;
 
-    cleanServerCache(server, t);
+    // Do not update cache if exception is from failing to submit action to thread pool
+    if (!(t instanceof RejectedExecutionException)) {

Review Comment:
   this receiveGlobalFailure method is private and only called in 3 places. Rather than add another instanceof check here, thoughts on just adding a boolean argument to the method `shouldClearCache`? We can pass in false everywhere, except in the place where we already `instanceof RejectedExecutionException` in sendMultiAction



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org