You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2021/02/24 17:21:43 UTC
[GitHub] [zookeeper] mariemat opened a new pull request #1614: ZOOKEEPER-4221: Improve the error message when message goes above jute.maxbufer size
mariemat opened a new pull request #1614:
URL: https://github.com/apache/zookeeper/pull/1614
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] symat commented on pull request #1614: ZOOKEEPER-4221: Improve the error message when message goes above jute.maxbufer size
Posted by GitBox <gi...@apache.org>.
symat commented on pull request #1614:
URL: https://github.com/apache/zookeeper/pull/1614#issuecomment-785936225
anyway, I just re-triggered the job. (actually there is only a single GitHub check that is running the java unit tests)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] symat commented on pull request #1614: ZOOKEEPER-4221: Improve the error message when message goes above jute.maxbufer size
Posted by GitBox <gi...@apache.org>.
symat commented on pull request #1614:
URL: https://github.com/apache/zookeeper/pull/1614#issuecomment-786280176
thanks @ztzg for the review! :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] mariemat commented on pull request #1614: ZOOKEEPER-4221: Improve the error message when message goes above jute.maxbufer size
Posted by GitBox <gi...@apache.org>.
mariemat commented on pull request #1614:
URL: https://github.com/apache/zookeeper/pull/1614#issuecomment-785334270
HI,
The CI failed with a timeout.
```
[INFO] -------------------------------------------------------
[INFO] T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.zookeeper.server.quorum.Zab1_0Test
[INFO] Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 23.352 s - in org.apache.zookeeper.server.quorum.Zab1_0Test
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 12, Failures: 0, Errors: 0, Skipped: 0
```
I reran the following successfully:
```
mvn -Dtest=Zab1_0Test -Pfull-build verify -Dsurefire-forkcount=1 -DskipCppUnit -Dsurefire.rerunFailingTestsCount=5
...
[INFO] -------------------------------------------------------
[INFO] T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.zookeeper.server.quorum.Zab1_0Test
[INFO] Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 23.352 s - in org.apache.zookeeper.server.quorum.Zab1_0Test
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 12, Failures: 0, Errors: 0, Skipped: 0
...
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 43.262 s
[INFO] Finished at: 2021-02-24T20:53:12+01:00
```
Is there a way to rerun the CI?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] asfgit closed pull request #1614: ZOOKEEPER-4221: Improve the error message when message goes above jute.maxbufer size
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1614:
URL: https://github.com/apache/zookeeper/pull/1614
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] ztzg commented on pull request #1614: ZOOKEEPER-4221: Improve the error message when message goes above jute.maxbufer size
Posted by GitBox <gi...@apache.org>.
ztzg commented on pull request #1614:
URL: https://github.com/apache/zookeeper/pull/1614#issuecomment-788696218
Hi @symat, thank you.
> @ztzg I merged this to master and branch-3.7. I think this can go to 3.7.0. Do I need to cherry-pick this to some 3.7.0 release branch, or you will cut a new release branch from branch-3.7 later?
Same as https://github.com/apache/zookeeper/pull/1611#issuecomment-787747977: don't worry about it, as I have to reconcile both branches anyway. I have added this ticket to my list of things to check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] symat commented on pull request #1614: ZOOKEEPER-4221: Improve the error message when message goes above jute.maxbufer size
Posted by GitBox <gi...@apache.org>.
symat commented on pull request #1614:
URL: https://github.com/apache/zookeeper/pull/1614#issuecomment-786530284
@ztzg I merged this to master and branch-3.7. I think this can go to 3.7.0. Do I need to cherry-pick this to some 3.7.0 release branch, or you will cut a new release branch from branch-3.7 later?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] symat commented on pull request #1614: ZOOKEEPER-4221: Improve the error message when message goes above jute.maxbufer size
Posted by GitBox <gi...@apache.org>.
symat commented on pull request #1614:
URL: https://github.com/apache/zookeeper/pull/1614#issuecomment-785912733
using the link on the failed GitHub CI job (the one with label "Details"), you can select "Rerun Jobs". But that would re-run all GitHub based CI jobs for this PR, and that potentially can cause more flaky tests. So I think this is good enough.
(we are working right now in the community to stabilize the CI for the master branch, as it is less reliable than it used to be)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] ztzg commented on pull request #1614: ZOOKEEPER-4221: Improve the error message when message goes above jute.maxbufer size
Posted by GitBox <gi...@apache.org>.
ztzg commented on pull request #1614:
URL: https://github.com/apache/zookeeper/pull/1614#issuecomment-792043513
> Hi @symat, thank you.
>
> > @ztzg I merged this to master and branch-3.7. I think this can go to 3.7.0. Do I need to cherry-pick this to some 3.7.0 release branch, or you will cut a new release branch from branch-3.7 later?
>
> Same as [#1611 (comment)](https://github.com/apache/zookeeper/pull/1611#issuecomment-787747977): don't worry about it, as I have to reconcile both branches anyway. I have added this ticket to my list of things to check.
Now also in `branch-3.7.0`. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] symat commented on pull request #1614: ZOOKEEPER-4221: Improve the error message when message goes above jute.maxbufer size
Posted by GitBox <gi...@apache.org>.
symat commented on pull request #1614:
URL: https://github.com/apache/zookeeper/pull/1614#issuecomment-786525907
I'm merging it now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] symat edited a comment on pull request #1614: ZOOKEEPER-4221: Improve the error message when message goes above jute.maxbufer size
Posted by GitBox <gi...@apache.org>.
symat edited a comment on pull request #1614:
URL: https://github.com/apache/zookeeper/pull/1614#issuecomment-785936225
anyway, I just re-triggered the job. (actually there is only a single GitHub check that is running the java unit tests)
it succeeded now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org