You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/05/05 15:20:52 UTC

[GitHub] [beam] bntnam commented on a change in pull request #11554: [BEAM-9876] Migrate the Beam website from Jekyll to Hugo to enable localization of the site content

bntnam commented on a change in pull request #11554:
URL: https://github.com/apache/beam/pull/11554#discussion_r420193221



##########
File path: website/www/site/content/en/documentation/transforms/java/elementwise/regex.md
##########
@@ -0,0 +1,34 @@
+---
+title: "Regex"
+---
+<!--
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+-->
+# Regex
+<table align="left">
+    <a target="_blank" class="button"
+        href="https://beam.apache.org/releases/javadoc/current/index.html?org/apache/beam/sdk/transforms/Regex.html">
+      <img src="https://beam.apache.org/images/logos/sdks/java.png" width="20px" height="20px"
+           alt="Javadoc" />
+     Javadoc
+    </a>
+</table>
+<br><br>

Review comment:
       In Jekyll, there was only one `<br>` at this line and once it was rendered, this `<br>` would be wrapped by `<p><br></p>`. In Hugo, `<br>` is still `<br>` after rendering so the spacing here is different. I don't wanna mimic `<p><br></p>` because it doesn't make sense, so I add one more `<br>` and now they have the same spacing.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org