You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "alessandro cosenza (JIRA)" <ji...@apache.org> on 2009/01/09 16:36:59 UTC

[jira] Created: (JCR-1932) bug in JCR API Session.getAttributes( ) call

bug in JCR API Session.getAttributes( ) call
--------------------------------------------

                 Key: JCR-1932
                 URL: https://issues.apache.org/jira/browse/JCR-1932
             Project: Jackrabbit
          Issue Type: Bug
          Components: JCR API
            Reporter: alessandro cosenza


Repository repository = new RMIRemoteRepository("//localhost:1099/jackrabbit.repository");
SimpleCredentials c = new SimpleCredentials("alex","ok".toCharArray());
c.setAttribute("anAttribute", "aValue");
Session s = repository.login(c, "aWorkspace");
String[]attr=s.getAttributeNames();

array attr is empty.
according to docs it should contains attributes from the SimpleCredentials object.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (JCR-1932) Session.getAttributes( ) call always returns an empty array

Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-1932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jukka Zitting resolved JCR-1932.
--------------------------------

       Resolution: Fixed
    Fix Version/s: 1.6.0

The protected setAttributes() method is a bit too much like an API enhancement to my taste, so I'd rather schedule this fix for release in Jackrabbit 1.6.0 instead of in 1.5.x.

However, if someone needs this functionality already in a 1.5.x release, then I wouldn't be too opposed to merging the change there.

> Session.getAttributes( ) call always returns an empty array
> -----------------------------------------------------------
>
>                 Key: JCR-1932
>                 URL: https://issues.apache.org/jira/browse/JCR-1932
>             Project: Jackrabbit Content Repository
>          Issue Type: Bug
>          Components: jackrabbit-core
>    Affects Versions: 0.9, 1.0, 1.1, 1.2.1, 1.3, 1.4, 1.5.0, 1.5.2
>            Reporter: alessandro cosenza
>            Assignee: Jukka Zitting
>            Priority: Minor
>             Fix For: 1.6.0
>
>         Attachments: bug.txt
>
>
> Repository repository = new RMIRemoteRepository("//localhost:1099/jackrabbit.repository");
> SimpleCredentials c = new SimpleCredentials("alex","ok".toCharArray());
> c.setAttribute("anAttribute", "aValue");
> Session s = repository.login(c, "aWorkspace");
> String[]attr=s.getAttributeNames();
> array attr is empty.
> according to docs it should contains attributes from the SimpleCredentials object.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (JCR-1932) Session.getAttributes( ) call always returns an empty array

Posted by "alessandro cosenza (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-1932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

alessandro cosenza updated JCR-1932:
------------------------------------

    Summary: Session.getAttributes( ) call always returns an empty array  (was: bug in JCR API Session.getAttributes( ) call)

> Session.getAttributes( ) call always returns an empty array
> -----------------------------------------------------------
>
>                 Key: JCR-1932
>                 URL: https://issues.apache.org/jira/browse/JCR-1932
>             Project: Jackrabbit
>          Issue Type: Bug
>          Components: JCR API
>            Reporter: alessandro cosenza
>         Attachments: bug.txt
>
>
> Repository repository = new RMIRemoteRepository("//localhost:1099/jackrabbit.repository");
> SimpleCredentials c = new SimpleCredentials("alex","ok".toCharArray());
> c.setAttribute("anAttribute", "aValue");
> Session s = repository.login(c, "aWorkspace");
> String[]attr=s.getAttributeNames();
> array attr is empty.
> according to docs it should contains attributes from the SimpleCredentials object.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (JCR-1932) Session.getAttributes( ) call always returns an empty array

Posted by "Alexander Klimetschek (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/JCR-1932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12662964#action_12662964 ] 

Alexander Klimetschek commented on JCR-1932:
--------------------------------------------

Looking at the SessionImpl code, I see that the member "attributes", which is read by getAttributeNames() and getAttribute(String) is never written to. The solution would be to change the RepositoryImpl.login(Credentials, String) method to pass on the attributes array through to createSession() -> createSessionInstance() -> XASessionImpl constructor -> SessionImpl constructor.

> Session.getAttributes( ) call always returns an empty array
> -----------------------------------------------------------
>
>                 Key: JCR-1932
>                 URL: https://issues.apache.org/jira/browse/JCR-1932
>             Project: Jackrabbit
>          Issue Type: Bug
>          Components: JCR API
>            Reporter: alessandro cosenza
>         Attachments: bug.txt
>
>
> Repository repository = new RMIRemoteRepository("//localhost:1099/jackrabbit.repository");
> SimpleCredentials c = new SimpleCredentials("alex","ok".toCharArray());
> c.setAttribute("anAttribute", "aValue");
> Session s = repository.login(c, "aWorkspace");
> String[]attr=s.getAttributeNames();
> array attr is empty.
> according to docs it should contains attributes from the SimpleCredentials object.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (JCR-1932) Session.getAttributes( ) call always returns an empty array

Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-1932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jukka Zitting updated JCR-1932:
-------------------------------

          Component/s:     (was: JCR API)
                       jackrabbit-core
             Priority: Minor  (was: Major)
    Affects Version/s: 1.0
                       1.0.1
                       1.1
                       1.1.1
                       1.2.1
                       1.2.2
                       1.2.3
                       1.3
                       1.3.1
                       1.3.3
                       1.3.4
                       1.4
                       core 1.4.1
                       core 1.4.2
                       core 1.4.3
                       core 1.4.4
                       core 1.4.5
                       core 1.4.6
                       1.5.0
                       core 1.4.7
                       1.5.2
                       core 1.4.8
             Assignee: Jukka Zitting

> Session.getAttributes( ) call always returns an empty array
> -----------------------------------------------------------
>
>                 Key: JCR-1932
>                 URL: https://issues.apache.org/jira/browse/JCR-1932
>             Project: Jackrabbit Content Repository
>          Issue Type: Bug
>          Components: jackrabbit-core
>    Affects Versions: 1.0, 1.0.1, 1.1, 1.1.1, 1.2.1, 1.2.2, 1.2.3, 1.3, 1.3.1, 1.3.3, 1.3.4, 1.4, core 1.4.1, core 1.4.2, core 1.4.3, core 1.4.4, core 1.4.5, core 1.4.6, 1.5.0, core 1.4.7, 1.5.2, core 1.4.8
>            Reporter: alessandro cosenza
>            Assignee: Jukka Zitting
>            Priority: Minor
>         Attachments: bug.txt
>
>
> Repository repository = new RMIRemoteRepository("//localhost:1099/jackrabbit.repository");
> SimpleCredentials c = new SimpleCredentials("alex","ok".toCharArray());
> c.setAttribute("anAttribute", "aValue");
> Session s = repository.login(c, "aWorkspace");
> String[]attr=s.getAttributeNames();
> array attr is empty.
> according to docs it should contains attributes from the SimpleCredentials object.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (JCR-1932) bug in JCR API Session.getAttributes( ) call

Posted by "alessandro cosenza (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-1932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

alessandro cosenza updated JCR-1932:
------------------------------------

    Attachment: bug.txt

> bug in JCR API Session.getAttributes( ) call
> --------------------------------------------
>
>                 Key: JCR-1932
>                 URL: https://issues.apache.org/jira/browse/JCR-1932
>             Project: Jackrabbit
>          Issue Type: Bug
>          Components: JCR API
>            Reporter: alessandro cosenza
>         Attachments: bug.txt
>
>
> Repository repository = new RMIRemoteRepository("//localhost:1099/jackrabbit.repository");
> SimpleCredentials c = new SimpleCredentials("alex","ok".toCharArray());
> c.setAttribute("anAttribute", "aValue");
> Session s = repository.login(c, "aWorkspace");
> String[]attr=s.getAttributeNames();
> array attr is empty.
> according to docs it should contains attributes from the SimpleCredentials object.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (JCR-1932) Session.getAttributes( ) call always returns an empty array

Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-1932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jukka Zitting updated JCR-1932:
-------------------------------

    Affects Version/s:     (was: core 1.4.8)
                           (was: core 1.4.7)
                           (was: core 1.4.6)
                           (was: core 1.4.5)
                           (was: core 1.4.4)
                           (was: core 1.4.3)
                           (was: core 1.4.2)
                           (was: core 1.4.1)
                           (was: 1.3.4)
                           (was: 1.3.3)
                           (was: 1.3.1)
                           (was: 1.2.3)
                           (was: 1.2.2)
                           (was: 1.1.1)
                           (was: 1.0.1)
                       0.9

In revision 744954 I added a protected SessionImpl.setAttribute method for this purpose. This avoids having to pass stuff through multiple methods and constructors.

> Session.getAttributes( ) call always returns an empty array
> -----------------------------------------------------------
>
>                 Key: JCR-1932
>                 URL: https://issues.apache.org/jira/browse/JCR-1932
>             Project: Jackrabbit Content Repository
>          Issue Type: Bug
>          Components: jackrabbit-core
>    Affects Versions: 0.9, 1.0, 1.1, 1.2.1, 1.3, 1.4, 1.5.0, 1.5.2
>            Reporter: alessandro cosenza
>            Assignee: Jukka Zitting
>            Priority: Minor
>         Attachments: bug.txt
>
>
> Repository repository = new RMIRemoteRepository("//localhost:1099/jackrabbit.repository");
> SimpleCredentials c = new SimpleCredentials("alex","ok".toCharArray());
> c.setAttribute("anAttribute", "aValue");
> Session s = repository.login(c, "aWorkspace");
> String[]attr=s.getAttributeNames();
> array attr is empty.
> according to docs it should contains attributes from the SimpleCredentials object.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.